branch-4.0: [improvement](fe) Migrate HMS client pool to Commons Pool #61553#61975
Open
github-actions[bot] wants to merge 1 commit intobranch-4.0from
Open
branch-4.0: [improvement](fe) Migrate HMS client pool to Commons Pool #61553#61975github-actions[bot] wants to merge 1 commit intobranch-4.0from
github-actions[bot] wants to merge 1 commit intobranch-4.0from
Conversation
### What problem does this PR solve? Problem Summary: This PR migrates `ThriftHMSCachedClient` from a self-managed queue-based HMS client pool to `commons-pool2` while keeping the external FE interface unchanged. It also clarifies the responsibility boundary of the HMS pool: - The pool only manages FE-side client lifecycle, including create, borrow/return, invalidate on failure, and destroy on close. - Hive-side socket lifetime and reconnect remain handled by `RetryingMetaStoreClient`. - The pool does not interpret `hive.metastore.client.socket.lifetime` or probe remote socket health. Additional changes in this PR: - Preserve throwable-based invalidation so failed borrowers are not returned to the pool. - Fix nested borrow hazards in `updateTableStatistics` and lock polling paths under strict pool limits. - Add FE unit coverage for normal return, invalidation, blocking borrow reuse, close behavior, and single-client nested-call behavior.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #61553