branch-4.1: [opt](memory) Remove unused indexId field from CloudReplica #62080#62097
Open
github-actions[bot] wants to merge 1 commit into
Open
branch-4.1: [opt](memory) Remove unused indexId field from CloudReplica #62080#62097github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
## Summary - Remove the `indexId` field and its `@SerializedName` from `CloudReplica`, saving 8 bytes per replica object - The only external usage is debug logging in `CloudTabletStatMgr` which already uses `stat.getIdx().getIndexId()` from the proto response — no change needed - Constructor parameter is kept for source compatibility but the value is no longer stored - Gson silently ignores unknown keys when deserializing old images, so backward compatibility is maintained ## Memory Impact -8 bytes/replica. At 10M replicas: ~76 MB saved. At 100M replicas: ~763 MB saved. ## Test plan - [ ] Existing cloud tests pass (`mvn test -pl fe/fe-core -Dtest="*Cloud*"`) - [ ] Gson backward compatibility: old-format JSON with "indexId" key deserializes without errors (silently ignored) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
2 similar comments
Contributor
|
run buildall |
Contributor
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage `` 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #62080