[refine](exec) remove unnecessary materialize_block_inplace calls#62229
Closed
Mryange wants to merge 1 commit intoapache:masterfrom
Closed
[refine](exec) remove unnecessary materialize_block_inplace calls#62229Mryange wants to merge 1 commit intoapache:masterfrom
Mryange wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Remove three redundant
materialize_block_inplacecalls where const column handling is already covered by downstream logic.1.
set_sink_operator.cpp_extract_build_columnalready checksis_column_const()and callsconvert_to_full_column_if_const()for each expression result column. The precedingmaterialize_block_inplaceon the raw input block is redundant.2.
vdata_stream_recvr.cppIn the local exchange path, blocks are enqueued and consumed by downstream operators that handle const columns themselves.
ColumnConst::allocated_bytes()correctly reports actual allocated memory, so memory tracking remains accurate without materialization.3.
multi_cast_data_stream_source.cppThe output block enters the pipeline and is processed by downstream operators, which handle const columns through their own expression evaluation. No need to materialize here.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)