Skip to content

branch-4.1:[fix](storage) fix IOContext Use-After-Free (#59947)#62241

Merged
yiguolei merged 3 commits into
apache:branch-4.1from
freemandealer:pick-branch-4.1-pr-59947-20260408-193616
Apr 24, 2026
Merged

branch-4.1:[fix](storage) fix IOContext Use-After-Free (#59947)#62241
yiguolei merged 3 commits into
apache:branch-4.1from
freemandealer:pick-branch-4.1-pr-59947-20260408-193616

Conversation

@freemandealer
Copy link
Copy Markdown
Member

Backport of #59947 to branch-4.1.

Original PR: #59947

No compile/test run for this pick.

@freemandealer freemandealer requested a review from yiguolei as a code owner April 8, 2026 11:39
@Thearas
Copy link
Copy Markdown
Contributor

Thearas commented Apr 8, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@freemandealer
Copy link
Copy Markdown
Member Author

run buildall

use shared_ptr instead of raw pointer to manage lifespan
of ioctx in storage layer.

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
(cherry picked from commit b6e8f69)
@freemandealer freemandealer force-pushed the pick-branch-4.1-pr-59947-20260408-193616 branch from 8bbc905 to d324b65 Compare April 22, 2026 18:18
Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
@freemandealer
Copy link
Copy Markdown
Member Author

run buildall

@hello-stephen
Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 17.65% (27/153) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.22% (19969/37519)
Line Coverage 36.70% (188133/512607)
Region Coverage 33.04% (146280/442712)
Branch Coverage 34.14% (64010/187476)

@hello-stephen
Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 69.93% (107/153) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.41% (26225/36726)
Line Coverage 54.31% (277469/510890)
Region Coverage 51.66% (230742/446649)
Branch Coverage 53.00% (99637/187998)

@freemandealer
Copy link
Copy Markdown
Member Author

run p0

@hello-stephen
Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 69.93% (107/153) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.42% (26229/36726)
Line Coverage 54.33% (277580/510890)
Region Coverage 51.69% (230883/446649)
Branch Coverage 53.01% (99665/187998)

@freemandealer
Copy link
Copy Markdown
Member Author

run p0

@hello-stephen
Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 69.93% (107/153) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.48% (26253/36726)
Line Coverage 54.37% (277786/510890)
Region Coverage 51.73% (231035/446649)
Branch Coverage 53.06% (99751/187998)

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Apr 24, 2026
@github-actions
Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit f15ec09 into apache:branch-4.1 Apr 24, 2026
27 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants