[fix](streaming-job) fix streaming job properties not parsed after FE restart#62298
Merged
JNSimba merged 2 commits intoapache:masterfrom Apr 13, 2026
Merged
Conversation
… restart After FE restart, StreamingJobProperties constructor was only called via gsonPostProcess() without validate(). When properties map was non-empty (e.g. max_interval=1), the old code skipped the isEmpty() branch and left maxIntervalSecond=0, causing timeoutMs=0 and every task to timeout immediately. Fix: parse properties directly in the constructor with safe fallback to defaults, so properties are always correctly initialized regardless of whether validate() is called. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildalll |
Member
Author
|
/review |
Contributor
There was a problem hiding this comment.
I found 2 issues in this patch.
StreamingJobPropertiesnow reconstructs persisted properties on FE restart, but the new fallback parser does not preserve the original validation contract fors3.max_batch_bytes.- The new restart regression test compares
SucceedTaskCountas strings, which makes the await flaky once the count reaches two digits.
Critical checkpoint conclusions:
- Goal of the task: Partially achieved. The
max_intervalreplay bug is addressed, but replay/default handling is still inconsistent for one persisted property, and the new regression test is brittle. - Modification size/focus: Yes, the code change is small and focused.
- Concurrency: No new concurrency or lock-order issues found in the changed code.
- Lifecycle/static initialization: No special lifecycle or static-init issues introduced.
- Configuration items: No new config added.
- Compatibility/incompatible changes: No protocol or storage-format incompatibility introduced.
- Parallel code paths: Not fully covered. The constructor is also used for S3 replay, and that path now diverges from
validate()semantics. - Special conditional checks: Timeout logging change is fine.
- Test coverage: FE unit test coverage improved, but the new regression case is flaky and there is still no regression that exercises the S3 replay/default path.
- Observability: Improved by the new timeout log.
- Transaction/persistence: This patch changes restart/replay behavior; one replay fallback remains inconsistent with create-time validation.
- Data writes/modifications: No direct write-path correctness issue found in this diff.
- FE/BE variable passing: Not applicable.
- Performance: No material performance issue found in the changed paths.
- Other issues: None beyond the findings below.
Member
Author
|
run buildall |
morrySnow
previously approved these changes
Apr 10, 2026
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Member
Author
|
run buildall |
Member
Author
|
run external |
Contributor
|
PR approved by at least one committer and no changes requested. |
catpineapple
approved these changes
Apr 13, 2026
github-actions bot
pushed a commit
that referenced
this pull request
Apr 13, 2026
… restart (#62298) ## Summary - After FE restart, `StreamingJobProperties` constructor was called via `gsonPostProcess()` without `validate()`. When properties map was non-empty (e.g. `max_interval=1`), the old code skipped the `isEmpty()` branch and left `maxIntervalSecond=0`, causing `timeoutMs=0` and every streaming task to timeout immediately. - Fix: parse properties directly in the constructor with safe fallback to defaults, so properties are always correctly initialized regardless of whether `validate()` is called. - Added timeout detection logging in `StreamingMultiTblTask.isTimeout()` for easier future debugging.
github-actions bot
pushed a commit
that referenced
this pull request
Apr 13, 2026
… restart (#62298) ## Summary - After FE restart, `StreamingJobProperties` constructor was called via `gsonPostProcess()` without `validate()`. When properties map was non-empty (e.g. `max_interval=1`), the old code skipped the `isEmpty()` branch and left `maxIntervalSecond=0`, causing `timeoutMs=0` and every streaming task to timeout immediately. - Fix: parse properties directly in the constructor with safe fallback to defaults, so properties are always correctly initialized regardless of whether `validate()` is called. - Added timeout detection logging in `StreamingMultiTblTask.isTimeout()` for easier future debugging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StreamingJobPropertiesconstructor was called viagsonPostProcess()withoutvalidate(). When properties map was non-empty (e.g.max_interval=1), the old code skipped theisEmpty()branch and leftmaxIntervalSecond=0, causingtimeoutMs=0and every streaming task to timeout immediately.validate()is called.StreamingMultiTblTask.isTimeout()for easier future debugging.Test plan
StreamingJobPropertiesTest- covers empty properties, explicit properties, bad values, and validate() behaviortest_streaming_mysql_job_restart_fe_with_props- creates job withmax_interval=5, restarts FE, verifies new data is consumed after restart🤖 Generated with Claude Code