Skip to content

branch-4.1: [fix](be) Restore workload group limit refresh after memory recovery #62070#62316

Merged
yiguolei merged 1 commit intobranch-4.1from
auto-pick-62070-branch-4.1
Apr 10, 2026
Merged

branch-4.1: [fix](be) Restore workload group limit refresh after memory recovery #62070#62316
yiguolei merged 1 commit intobranch-4.1from
auto-pick-62070-branch-4.1

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Cherry-picked from #62070

…62070)

### What problem does this PR solve?

Problem Summary: 
1. Refresh_workload_group_memory_state() returned early when aggregate
workload-group memory usage was zero. That skipped
update_queries_limit_(), so per-query memory limits could stay
artificially low after memory pressure had already eased.
2. Paused workload queries were not handled correctly around recent
query cancellation. The manager could return too early, fail to clear
resumed or expired paused entries, and skip restoring effective query
memory limits under recovery. This change fixes those branches and adds
unit tests that directly cover the recent-cancel and Phase 3 cleanup
paths.
   

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions bot requested a review from yiguolei as a code owner April 10, 2026 04:40
@Thearas
Copy link
Copy Markdown
Contributor

Thearas commented Apr 10, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Apr 10, 2026
@Thearas
Copy link
Copy Markdown
Contributor

Thearas commented Apr 10, 2026

run buildall

@yiguolei
Copy link
Copy Markdown
Contributor

skip buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 10, 2026
@github-actions
Copy link
Copy Markdown
Contributor Author

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor Author

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 806d82c into branch-4.1 Apr 10, 2026
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants