[fix](compile) Remove stale compile_check includes from schema_role_mappings_scanner#62343
Open
dataroaring wants to merge 1 commit intoapache:masterfrom
Open
[fix](compile) Remove stale compile_check includes from schema_role_mappings_scanner#62343dataroaring wants to merge 1 commit intoapache:masterfrom
dataroaring wants to merge 1 commit intoapache:masterfrom
Conversation
…appings_scanner PR apache#62077 added schema_role_mappings_scanner.cpp with compile_check_begin/end.h includes, but PR apache#62300 subsequently deleted those headers globally. This causes a compile failure on master: 'common/compile_check_begin.h' file not found. Generated by Claude Code
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
3 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a build break on master by removing references to deleted compile-check wrapper headers from the BE information_schema role mappings scanner.
Changes:
- Removed stale
common/compile_check_begin.h/common/compile_check_end.hincludes fromschema_role_mappings_scanner.cpp.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#include "common/compile_check_begin.h"and#include "common/compile_check_end.h"fromschema_role_mappings_scanner.cppschema_role_mappings_scanner.cpp(added by [feature](fe) Add information_schema role mappings table #62077) still referenced them, causing a compile failure on masterRoot Cause
PR #62077 and PR #62300 were prepared independently. #62077 added a new file with the compile_check includes, while #62300 deleted those headers. After both merged, master fails to compile with:
Test plan
🤖 Generated with Claude Code