Skip to content

[Enhancement](dependency)optimize the Lists package for unified reference#62379

Merged
yiguolei merged 5 commits intoapache:masterfrom
LuGuangming:master_Lists_optimize
Apr 15, 2026
Merged

[Enhancement](dependency)optimize the Lists package for unified reference#62379
yiguolei merged 5 commits intoapache:masterfrom
LuGuangming:master_Lists_optimize

Conversation

@LuGuangming
Copy link
Copy Markdown
Contributor

@LuGuangming LuGuangming commented Apr 11, 2026

What problem does this PR solve?

Issue Number: close #62378

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morrySnow
Copy link
Copy Markdown
Contributor

it is better add a checkstyle rule to reject org.apache.hadoop.util.Lists

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 13, 2026
@github-actions
Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@yiguolei
Copy link
Copy Markdown
Contributor

run buildall

@yiguolei
Copy link
Copy Markdown
Contributor

/review

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found in this PR. The change is a narrow dependency/import cleanup that replaces org.apache.hadoop.util.Lists with com.google.common.collect.Lists in five FE Java files, and each touched call site (newArrayListWithCapacity, newArrayList) is API-compatible with Guava.

Critical checkpoint conclusions:

  • Goal / correctness: The goal is to unify Lists imports away from Hadoop util. The patch achieves that goal, and I found no behavioral change in the touched logic paths.
  • Scope / minimality: The modification is as small and focused as possible: import-only changes in five files, no control-flow or data-flow changes.
  • Concurrency: No new concurrency, locks, or thread-safety impact in this patch.
  • Lifecycle / initialization: No lifecycle or static-initialization changes.
  • Configuration: No config additions or dynamic-config concerns.
  • Compatibility: No FE-BE protocol, storage-format, or rolling-upgrade compatibility impact.
  • Parallel code paths: The touched usages are updated consistently within this PR; no missed sibling path was evident from the remaining tree search for org.apache.hadoop.util.Lists.
  • Special conditional checks: No new conditions introduced.
  • Test coverage: This patch does not change runtime logic, so lack of dedicated new tests is acceptable. I did not identify a scenario that would require new regression or unit coverage beyond normal compile/test coverage.
  • Observability: No new observability requirements.
  • Transaction / persistence: Not involved.
  • Data writes / atomicity: Not involved.
  • FE-BE variable passing: Not involved.
  • Performance: Neutral to slightly positive from removing the Hadoop utility dependency usage; no hot-path regression introduced.
  • Other issues: None identified in the touched code.

Module-specific conclusions:

  • FE core review points: No lock, exception-boundary, or visible-version behavior changed.
  • Nereids review points: No rule semantics, stage ordering, mark-join handling, or property-derivation logic changed; only imports were adjusted.

Residual risk:

  • Very low. The only meaningful risk would be compile-time fallout if a touched file depended on a Hadoop-specific Lists API, and that is not the case here.

@yiguolei yiguolei merged commit c693e72 into apache:master Apr 15, 2026
34 of 35 checks passed
seawinde pushed a commit to seawinde/doris that referenced this pull request Apr 15, 2026
…ence (apache#62379)

### What problem does this PR solve?

Issue Number: close apache#62378

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [x] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [x] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [x] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] optimize the Lists package for unified reference

4 participants