[Enhancement](dependency)optimize the Lists package for unified reference#62379
Merged
yiguolei merged 5 commits intoapache:masterfrom Apr 15, 2026
Merged
[Enhancement](dependency)optimize the Lists package for unified reference#62379yiguolei merged 5 commits intoapache:masterfrom
yiguolei merged 5 commits intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
morrySnow
approved these changes
Apr 13, 2026
Contributor
|
it is better add a checkstyle rule to reject |
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
yiguolei
approved these changes
Apr 15, 2026
Contributor
|
run buildall |
Contributor
|
/review |
Contributor
There was a problem hiding this comment.
No blocking issues found in this PR. The change is a narrow dependency/import cleanup that replaces org.apache.hadoop.util.Lists with com.google.common.collect.Lists in five FE Java files, and each touched call site (newArrayListWithCapacity, newArrayList) is API-compatible with Guava.
Critical checkpoint conclusions:
- Goal / correctness: The goal is to unify
Listsimports away from Hadoop util. The patch achieves that goal, and I found no behavioral change in the touched logic paths. - Scope / minimality: The modification is as small and focused as possible: import-only changes in five files, no control-flow or data-flow changes.
- Concurrency: No new concurrency, locks, or thread-safety impact in this patch.
- Lifecycle / initialization: No lifecycle or static-initialization changes.
- Configuration: No config additions or dynamic-config concerns.
- Compatibility: No FE-BE protocol, storage-format, or rolling-upgrade compatibility impact.
- Parallel code paths: The touched usages are updated consistently within this PR; no missed sibling path was evident from the remaining tree search for
org.apache.hadoop.util.Lists. - Special conditional checks: No new conditions introduced.
- Test coverage: This patch does not change runtime logic, so lack of dedicated new tests is acceptable. I did not identify a scenario that would require new regression or unit coverage beyond normal compile/test coverage.
- Observability: No new observability requirements.
- Transaction / persistence: Not involved.
- Data writes / atomicity: Not involved.
- FE-BE variable passing: Not involved.
- Performance: Neutral to slightly positive from removing the Hadoop utility dependency usage; no hot-path regression introduced.
- Other issues: None identified in the touched code.
Module-specific conclusions:
- FE core review points: No lock, exception-boundary, or visible-version behavior changed.
- Nereids review points: No rule semantics, stage ordering, mark-join handling, or property-derivation logic changed; only imports were adjusted.
Residual risk:
- Very low. The only meaningful risk would be compile-time fallout if a touched file depended on a Hadoop-specific
ListsAPI, and that is not the case here.
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Apr 15, 2026
…ence (apache#62379) ### What problem does this PR solve? Issue Number: close apache#62378 Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [x] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [x] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [x] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #62378
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)