Skip to content

[refactor](be) Replace std::unique_ptr with DorisUniqueBufferPtr in SingleValueDataString (#62374)#62408

Merged
yiguolei merged 1 commit intoapache:branch-4.1from
mrhhsg:pick_62374
Apr 13, 2026
Merged

[refactor](be) Replace std::unique_ptr with DorisUniqueBufferPtr in SingleValueDataString (#62374)#62408
yiguolei merged 1 commit intoapache:branch-4.1from
mrhhsg:pick_62374

Conversation

@mrhhsg
Copy link
Copy Markdown
Member

@mrhhsg mrhhsg commented Apr 12, 2026

Pick #62374

Problem Summary: SingleValueDataString uses std::unique_ptr<char[]> with new[] for large string storage, which bypasses the Doris memory tracking allocator. This replaces it with DorisUniqueBufferPtr so that allocations go through Allocator and are properly tracked.

None

  • Test: Unit Test (added SingleValueDataStringTest)
  • Behavior changed: No
  • Does this need documentation: No

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

None

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
  • This is a refactor/code format and no logic has been changed.
    - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason

  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
  • Yes.

  • Confirm the release note

  • Confirm test cases

  • Confirm document

  • Add branch pick label

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

…ingleValueDataString (apache#62374)

Issue Number: close #xxx

Problem Summary: SingleValueDataString uses std::unique_ptr<char[]> with
new[] for large string storage, which bypasses the Doris memory tracking
allocator. This replaces it with DorisUniqueBufferPtr<char> so that
allocations go through Allocator and are properly tracked.

None

- Test: Unit Test (added SingleValueDataStringTest)
- Behavior changed: No
- Does this need documentation: No

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

None

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@mrhhsg mrhhsg requested a review from yiguolei as a code owner April 12, 2026 09:11
@mrhhsg
Copy link
Copy Markdown
Member Author

mrhhsg commented Apr 12, 2026

run buildall

@Thearas
Copy link
Copy Markdown
Contributor

Thearas commented Apr 12, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen
Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 100.00% (3/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.97% (19878/37524)
Line Coverage 36.54% (187254/512519)
Region Coverage 32.86% (145424/442530)
Branch Coverage 33.99% (63705/187431)

@hello-stephen
Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (3/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.48% (26255/36731)
Line Coverage 54.37% (277737/510802)
Region Coverage 51.69% (230795/446474)
Branch Coverage 53.09% (99786/187957)

@yiguolei yiguolei merged commit a653a86 into apache:branch-4.1 Apr 13, 2026
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants