branch-4.1: [fix](eagerAgg) Fix eager aggregation incorrectly pushing agg(literal) to nullable side of outer joins #62107#62456
Open
github-actions[bot] wants to merge 2 commits into
Open
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
1 similar comment
Contributor
|
run buildall |
…) to nullable side of outer joins (#62107) ### What problem does this PR solve? Issue Number: close #xxx Problem Summary: The EagerAggRewriter only blocked count(*)/count(literal) from being pushed to the nullable side of outer joins (via instanceof Count check). But the same logic applies to ALL aggregate functions whose input slots do not reference columns from the target side, e.g. sum(2), min(1), max(3). For unmatched rows in outer joins, these aggregates should produce their literal-based result (e.g. sum(2) adds 2 per unmatched row). After incorrect pushdown to the nullable side, the pre-aggregated slot becomes NULL for unmatched rows, and sum(NULL)/min(NULL)/max(NULL) loses the contribution entirely. The fix generalizes the existing Count-only guard to all aggregate functions: for any agg function with no input slots from the target side, block pushdown to the nullable side of outer joins. agg(nullable_side_col) is still safe to push because NULL values are naturally handled by aggregates.
englefly
force-pushed
the
auto-pick-62107-branch-4.1
branch
from
15c10d0 to
4dd4503
Compare
Contributor
|
run buildall |
Contributor
FE Regression Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #62107