1

[zclllyybb]

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

• Test

  • Regression test
  • Unit Test
  • Manual test (add detailed scripts or steps below)
  • No need to test or manual test. Explain why:
    • This is a refactor/code format and no logic has been changed.
    • Previous test can cover this change.
    • No code files have been changed.
    • Other reason

• Behavior changed:

  • No.
  • Yes.

• Does this need documentation?

  • No.
  • Yes.

Check List (For Reviewer who merge this PR)

• Confirm the release note
• Confirm test cases
• Confirm document
• Add branch pick label

[Thearas]

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?

[zclllyybb]

/review

[github-actions]

Findings:

1. be/test/exec/exchange/exchange_sink_test.h: removing the direct includes makes this header non-self-contained and breaks the only inclusion site. exchange_sink_test.cpp includes this header before <gtest/gtest.h> and exec/operator/exchange_sink_buffer.h, so names used directly in the header such as testing::Test, std::map, std::queue, Status, ExchangeSinkBuffer, AutoReleaseClosure, and PBackendService_Stub are no longer declared when the compiler parses this file. That turns this cleanup into an immediate BE test compile failure.

2. be/test/exec/exchange/exchange_sink_test.h: removing the opening namespace doris { also leaves the helper declarations at global scope and makes the existing }; // namespace doris near transmit_blockv2() an unmatched close. This file no longer parses even before considering the missing includes.

Critical checkpoints:

• Goal of current task: The apparent goal is to simplify exchange_sink_test.h. The current patch does not accomplish that safely because it breaks compilation of the test target. No test evidence is provided.
• Scope and minimality: The patch is small, but not correct; it removes required declarations rather than only removing dead code.
• Concurrency: No new concurrency behavior is introduced by this patch.
• Lifecycle / static initialization: Not applicable for this change.
• Configuration changes: None.
• Compatibility changes: None.
• Parallel code paths: Not applicable.
• Special conditional checks: None added.
• Test coverage: No new or updated tests. More importantly, the existing test appears unable to compile after this change.
• Test results modified: None.
• Observability: Not applicable.
• Transaction / persistence: Not applicable.
• Data writes / modifications: Not applicable.
• FE-BE variable passing: Not applicable.
• Performance: No meaningful performance impact; correctness blocks merge first.
• Other issues: The PR title/body and commit message are placeholders, but the compile break is the blocking issue.

Overall opinion: request changes until the header remains self-contained and syntactically valid.

[github-actions]

Removing these includes breaks the only inclusion site of this header. exchange_sink_test.cpp includes exchange_sink_test.h before it includes <gtest/gtest.h> or exec/operator/exchange_sink_buffer.h, but this header uses testing::Test, std::map, std::queue, Status, ExchangeSinkBuffer, AutoReleaseClosure, and PBackendService_Stub directly. After this deletion the test no longer compiles, so the header still needs to include the declarations it depends on instead of relying on transitive include order.

[github-actions]

Removing the opening namespace doris { makes the helper declarations above ExchangeSinkTest leave the namespace and also turns the existing }; // namespace doris after transmit_blockv2() into an unmatched close. This is a syntax error even before the missing includes are considered.