Skip to content

branch-4.1: [fix](streaming-job) Fix NPE in StreamingInsertJob.replayOnCommitted during EditLog replay #62416 #62516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiguolei merged 1 commit into from
Apr 16, 2026
Merged

branch-4.1: [fix](streaming-job) Fix NPE in StreamingInsertJob.replayOnCommitted during EditLog replay #62416 #62516

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ...re/src/main/java/org/apache/doris/job/extensions/insert/streaming/StreamingInsertJob.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1021,13 +1021,13 @@ public long getId() {

@Override
public void beforeCommitted(TransactionState txnState) throws TransactionException {
boolean shouldReleaseLock = false;
writeLock();
boolean passCheck = false;
try {
if (runningStreamTask.getIsCanceled().get()) {
log.info("streaming insert job {} task {} is canceled, skip beforeCommitted",
getJobId(), runningStreamTask.getTaskId());
return;
throw new TransactionException("streaming insert job " + getJobId()
+ " task " + runningStreamTask.getTaskId()
+ " is canceled, txn " + txnState.getTransactionId() + " could not be committed");
}

ArrayList<Long> taskIds = new ArrayList<>();
Expand All @@ -1046,7 +1046,6 @@ public void beforeCommitted(TransactionState txnState) throws TransactionExcepti
runningStreamTask.getTaskId(),
runningStreamTask.getScanBackendIds());


if (StringUtils.isBlank(offsetJson)) {
throw new TransactionException("Cannot find offset for attachment, load job id is "
+ runningStreamTask.getTaskId());
Expand All @@ -1059,8 +1058,9 @@ public void beforeCommitted(TransactionState txnState) throws TransactionExcepti
loadStatistic.getFileNumber(),
loadStatistic.getTotalFileSizeB(),
offsetJson));
passCheck = true;
} finally {
if (shouldReleaseLock) {
if (!passCheck) {
writeUnlock();
}
}
Expand Down
Loading