Skip to content

branch-4.1: [chore](http) Merge ms and recycler http skeleton #61502#62603

Merged
hello-stephen merged 2 commits into
branch-4.1from
auto-pick-61502-branch-4.1
Apr 23, 2026
Merged

branch-4.1: [chore](http) Merge ms and recycler http skeleton #61502#62603
hello-stephen merged 2 commits into
branch-4.1from
auto-pick-61502-branch-4.1

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Cherry-picked from #61502

### What problem does this PR solve?

Problem Summary: Meta service and recycler maintained duplicated HTTP
parsing, routing, and config handling logic, which made it harder to
reuse handlers and keep versioned endpoints consistent. This change
extracts the shared HTTP helper layer into `cloud/src/common/
http_helper.*`, introduces role-based handler registration for
MetaService and Recycler, reuses common config show/update helpers, and
adds versioned cluster HTTP test coverage.

If you want to expand the interface version

```
{"add_cluster",
 {.handler = [](void* s, brpc::Controller* c) { return process_alter_cluster((MS*)s, c); },
  .versioned_handlers =
          {{"v2",
            [](void* s, brpc::Controller* c) {
                return process_alter_cluster_v2((MS*)s, c);
            }}},
  .role = HttpRole::META_SERVICE}},
```
@github-actions github-actions Bot requested a review from yiguolei as a code owner April 19, 2026 13:53
@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Apr 19, 2026
@hello-stephen
Copy link
Copy Markdown
Contributor

run buildall

@yiguolei yiguolei closed this Apr 23, 2026
@yiguolei yiguolei reopened this Apr 23, 2026
@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Apr 23, 2026
@github-actions
Copy link
Copy Markdown
Contributor Author

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor Author

PR approved by anyone and no changes requested.

@yiguolei yiguolei closed this Apr 23, 2026
@yiguolei yiguolei reopened this Apr 23, 2026
@hello-stephen
Copy link
Copy Markdown
Contributor

skip buildall

@hello-stephen hello-stephen merged commit 55e6e2b into branch-4.1 Apr 23, 2026
30 of 31 checks passed
@hello-stephen hello-stephen deleted the auto-pick-61502-branch-4.1 branch April 23, 2026 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants