[fix](statistics) Fix missing Mockito import in AnalysisManagerTest#62720
Merged
mrhhsg merged 1 commit intoApr 22, 2026
Merged
Conversation
### What problem does this PR solve? Problem Summary: AnalysisManagerTest in the adaptive_batch_size branch is missing the 'import org.mockito.Mockito;' statement needed by the Mockito-based test methods introduced in apache#62686. Without this import the FE build fails at compilation. ### Release note None ### Check List (For Author) - Test: No need to test (compile fix only) - Behavior changed: No - Does this need documentation: No Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
Author
|
/review |
Contributor
There was a problem hiding this comment.
No blocking findings.
Review conclusion: approve.
Critical checkpoints:
- Goal of the current task: Met. The PR adds the missing
org.mockito.Mockitoimport required by existing Mockito calls inAnalysisManagerTestat the PR head. The base commit already contains thoseMockito.*usages without the import, so this is a real compile-fix. - Minimality and focus: Met. This is a single-file, one-line, test-only change and is as small as possible.
- Concurrency: Not applicable. No concurrent or lock-sensitive runtime code is changed.
- Lifecycle and static initialization: Not applicable. No lifecycle or static initialization logic is touched.
- Configuration changes: Not applicable. No config is added or modified.
- Compatibility and incompatible changes: Not applicable. No FE-BE protocol, API surface, symbol, or storage-format change is involved.
- Functionally parallel code paths: Not applicable. This patch only fixes the test import in the affected file.
- Special conditional checks: Not applicable. No new conditional logic is introduced.
- Test coverage: Acceptable for a compile-fix. The existing Mockito-based tests are already present in this file; this import is what allows them to compile. I could not run the prescribed FE build or test flow locally because
thirdparty/installed/bin/protocis missing in this runner, which blocks thefe/AGENTS.mdbuild prerequisites. - Observability: Not applicable. No runtime behavior changes.
- Transaction and persistence: Not applicable. Not involved.
- Data writes and modifications: Not applicable. Not involved.
- FE-BE variable passing: Not applicable. Not involved.
- Performance: No impact.
- Other issues: None found in the PR diff.
Based on the patch scope and the evidence above, I do not see any blocking issue in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: N/A
Related PR: #62710
Problem Summary:
AnalysisManagerTestin theadaptive_batch_sizebranch is missing theimport org.mockito.Mockito;statement needed by the Mockito-based test methods introduced in #62686/#62710. Without this import the FE build fails at compilation withcannot find symbol: variable Mockito.Release note
None
Check List (For Author)