[fix](ddl) reject invalid IPv4 default value at CREATE TABLE time#62906
Open
924060929 wants to merge 1 commit into
Open
[fix](ddl) reject invalid IPv4 default value at CREATE TABLE time#62906924060929 wants to merge 1 commit into
924060929 wants to merge 1 commit into
Conversation
IPv4Literal.parseIPv4toLong silently returned 0L for invalid input, causing ColumnDef.validateDefaultValue to accept garbage like 'not_an_ip'. Change it to throw AnalysisException instead.
Contributor
Author
|
run buildall |
1 similar comment
Contributor
Author
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage `` 🎉 |
Contributor
FE Regression Coverage ReportIncrement line coverage |
1 similar comment
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
TPC-H: Total hot run time: 29313 ms |
Contributor
TPC-DS: Total hot run time: 171658 ms |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
IPv4Literal.parseIPv4toLongsilently returned0Lfor invalid input (e.g.'not_an_ip'), soColumnDef.validateDefaultValueaccepted any string as an IPv4 default value at CREATE TABLE time. The invalid default only fails later at INSERT/stream load time.Changed the three
return 0Lerror paths tothrow AnalysisException, matching the behavior ofIPv6Literalwhich already rejects invalid defaults at DDL time.Check List (For Author)
Test
Behavior changed:
ip IPV4 DEFAULT 'not_an_ip') are now rejected at CREATE TABLE time instead of being silently accepted.Does this need documentation?
Check List (For Reviewer who merge this PR)