Skip to content

[chore](regression-test) fix some unstable cases#62922

Merged
airborne12 merged 1 commit into
apache:masterfrom
eldenmoon:case-stable
May 7, 2026
Merged

[chore](regression-test) fix some unstable cases#62922
airborne12 merged 1 commit into
apache:masterfrom
eldenmoon:case-stable

Conversation

@eldenmoon
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings April 29, 2026 03:36
@eldenmoon
Copy link
Copy Markdown
Member Author

run buildall

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to reduce regression-test flakiness in the VARIANT nested test area by removing several unstable/obsolete suites, and adds a new export/load regression to exercise wide VARIANT payloads with S3.

Changes:

  • Removed multiple variant_p0 nested-related regression suites and an associated SQL file.
  • Added a new export_p2 regression suite that stream-loads sparse wide VARIANT data, exports it to S3, validates via S3 TVF, then loads it back and spot-checks correctness.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
regression-test/suites/variant_p0/nested2.groovy Removed an (effectively disabled) nested type-conflict suite.
regression-test/suites/variant_p0/nested/sql/q01.sql Removed SQL verification file tied to removed nested load coverage.
regression-test/suites/variant_p0/nested/nested_in_top_array.groovy Removed nested-in-top-array VARIANT suite (previously exercising type/structure conflicts).
regression-test/suites/variant_p0/nested/load.groovy Removed a TODO/disabled nested-load suite.
regression-test/suites/variant_p0/nested.groovy Removed a large VARIANT nested regression suite.
regression-test/suites/export_p2/test_export_variant_10k_columns.groovy Added new S3 export/TVF validation/load-back regression for wide VARIANT data.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@eldenmoon
Copy link
Copy Markdown
Member Author

run p0

Copy link
Copy Markdown
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@airborne12 airborne12 merged commit 30d9109 into apache:master May 7, 2026
36 of 37 checks passed
@eldenmoon eldenmoon deleted the case-stable branch May 7, 2026 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants