branch-4.1: [refactor](ann) Avoid copying ANN search results #62924#63002
Open
zhiqiang-hhhh wants to merge 1 commit intoapache:branch-4.1from
Open
branch-4.1: [refactor](ann) Avoid copying ANN search results #62924#63002zhiqiang-hhhh wants to merge 1 commit intoapache:branch-4.1from
zhiqiang-hhhh wants to merge 1 commit intoapache:branch-4.1from
Conversation
Issue Number: close #xxx Related PR: #xxx Problem Summary: ANN TopN copied distance results into an intermediate vector before materializing the virtual column, and row id ownership was moved through several wrappers. This refactors ANN search result ownership to share the generated buffers directly and removes the redundant update_result helper. None - Test: Unit Test - ./run-be-ut.sh --run --filter=AnnTopNRuntimeEvaluateTopN:AnnTopNRuntimeEvaluate_DimensionMismatch:AnnIndexReaderTest.TestQueryWithoutLoadIndex:AnnIndexReaderTest.TestQueryIVFWithoutLoadIndex:VirtualColumnIteratorTest.* - Behavior changed: No - Does this need documentation: No
Contributor
Author
|
run buildall |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry pick from #62924