[fix](be) explicitly close stream load recorder RocksDB on shutdown#63004
Open
sollhui wants to merge 1 commit intoapache:masterfrom
Open
[fix](be) explicitly close stream load recorder RocksDB on shutdown#63004sollhui wants to merge 1 commit intoapache:masterfrom
sollhui wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
e478eb4 to
2f9a376
Compare
Contributor
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 29363 ms |
Contributor
TPC-DS: Total hot run time: 171346 ms |
2f9a376 to
be1f8ad
Compare
Contributor
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 29330 ms |
Contributor
TPC-DS: Total hot run time: 171093 ms |
be1f8ad to
eacdc0f
Compare
Contributor
Author
|
run buildall |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
TPC-H: Total hot run time: 29487 ms |
Contributor
TPC-DS: Total hot run time: 171971 ms |
eacdc0f to
563b1b4
Compare
Contributor
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 29761 ms |
Contributor
TPC-DS: Total hot run time: 170876 ms |
563b1b4 to
2208e5f
Compare
Contributor
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 29358 ms |
Contributor
TPC-DS: Total hot run time: 169822 ms |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
Explicitly close the RocksDB instance used by
StreamLoadRecorderduring destruction.Previously,
StreamLoadRecorder::~StreamLoadRecorder()only destroyed column family handles and synced WAL, then relied onDBWithTTLdestruction to close RocksDB implicitly. If BE failed during startup, for example becausebe_portwas already occupied, shutdown cleanup could enter RocksDBDBImpl::CloseHelper()from the implicit destructor path and crash while unscheduling background work.This patch makes the shutdown sequence explicit:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)