Skip to content

branch-4.1: [fix](cloud) Skip skewed warmup rowset latency samples #62941#63084

Merged
yiguolei merged 1 commit into
branch-4.1from
auto-pick-62941-branch-4.1
May 9, 2026
Merged

branch-4.1: [fix](cloud) Skip skewed warmup rowset latency samples #62941#63084
yiguolei merged 1 commit into
branch-4.1from
auto-pick-62941-branch-4.1

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented May 8, 2026

Cherry-picked from #62941

Issue Number: None

Problem Summary: CORE-6051 reports negative file_cache_warm_up_rowset_request_to_handle_ samples. The request timestamp is produced on the caller BE while handle and finish timestamps are produced on the target BE, so cross-host wall-clock skew can make the interval negative and bvar drops it. Skip cross-host latency samples when the request timestamp is missing or later than the local timestamp.

Release note: Fix file cache warm-up rowset latency metrics to skip invalid cross-BE clock-skew samples.
@github-actions github-actions Bot requested a review from yiguolei as a code owner May 8, 2026 11:09
@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen
Copy link
Copy Markdown
Contributor

run buildall

@hello-stephen
Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/36) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.48% (27100/36880)
Line Coverage 57.02% (292440/512834)
Region Coverage 54.50% (244457/448535)
Branch Coverage 56.15% (106067/188896)

@yiguolei yiguolei merged commit cd7f165 into branch-4.1 May 9, 2026
28 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants