Skip to content

Fix parquet row group reader lifetime issues#63101

Merged
Gabriel39 merged 1 commit intoapache:mc-test-branch-4.1from
Gabriel39:mc-test-branch-4.1
May 9, 2026
Merged

Fix parquet row group reader lifetime issues#63101
Gabriel39 merged 1 commit intoapache:mc-test-branch-4.1from
Gabriel39:mc-test-branch-4.1

Conversation

@Gabriel39
Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Gabriel39 Gabriel39 requested a review from yiguolei as a code owner May 9, 2026 07:41
@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Gabriel39
Copy link
Copy Markdown
Contributor Author

/review

@Gabriel39 Gabriel39 merged commit 123f165 into apache:mc-test-branch-4.1 May 9, 2026
13 of 18 checks passed
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review result: no blocking issues found.\n\nCritical checkpoints:\n- Repository instructions: no AGENTS.md or in-repo code-review skill file was present in the workspace; I followed the supplied automated review instructions and existing-review context.\n- Existing review threads: none were present, so no duplicate concerns were submitted.\n- Scope reviewed: full PR diff reviewed; changes are limited to be/src/format/parquet/vparquet_group_reader.cpp and be/src/format/parquet/vparquet_group_reader.h.\n- Correctness/lifetime: moving _column_readers after _read_ranges makes member destruction release readers before _read_ranges, matching the reader reference lifetime requirement. Removing the explicit _column_readers.clear() avoids fighting declaration-order destruction and leaves file_reader/state/raw references with adequate lifetime for reader teardown.\n- Tests/verification: git diff --check passed; no focused runtime test was available from the PR.\n- User focus: no additional user-provided review focus was specified.

Gabriel39 added a commit to Gabriel39/incubator-doris that referenced this pull request May 9, 2026
Gabriel39 added a commit to Gabriel39/incubator-doris that referenced this pull request May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants