Fix parquet row group reader lifetime issues#63101
Fix parquet row group reader lifetime issues#63101Gabriel39 merged 1 commit intoapache:mc-test-branch-4.1from
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
/review |
There was a problem hiding this comment.
Review result: no blocking issues found.\n\nCritical checkpoints:\n- Repository instructions: no AGENTS.md or in-repo code-review skill file was present in the workspace; I followed the supplied automated review instructions and existing-review context.\n- Existing review threads: none were present, so no duplicate concerns were submitted.\n- Scope reviewed: full PR diff reviewed; changes are limited to be/src/format/parquet/vparquet_group_reader.cpp and be/src/format/parquet/vparquet_group_reader.h.\n- Correctness/lifetime: moving _column_readers after _read_ranges makes member destruction release readers before _read_ranges, matching the reader reference lifetime requirement. Removing the explicit _column_readers.clear() avoids fighting declaration-order destruction and leaves file_reader/state/raw references with adequate lifetime for reader teardown.\n- Tests/verification: git diff --check passed; no focused runtime test was available from the PR.\n- User focus: no additional user-provided review focus was specified.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)