[Feature] support binlog<row> read and write (row type) (2/3)#63110
Open
Userwhite wants to merge 10 commits into
Open
[Feature] support binlog<row> read and write (row type) (2/3)#63110Userwhite wants to merge 10 commits into
Userwhite wants to merge 10 commits into
Conversation
Userwhite
requested review from
dataroaring,
gavinchou and
yiguolei
as code owners
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
/review |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
Contributor
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
TPC-DS: Total hot run time: 66541 ms |
Contributor
TPC-DS: Total hot run time: 71162 ms |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
Contributor
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
TPC-DS: Total hot run time: 70442 ms |
Contributor
TPC-DS: Total hot run time: 57471 ms |
Contributor
Author
|
run buildall |
Contributor
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
2 similar comments
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
TPC-DS: Total hot run time: 61024 ms |
Contributor
Author
|
run beut |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 29731 ms |
Contributor
TPC-DS: Total hot run time: 169763 ms |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
gavinchou
previously approved these changes
May 15, 2026
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
TPC-H: Total hot run time: 31563 ms |
Contributor
TPC-DS: Total hot run time: 170583 ms |
Contributor
Author
|
run buildall |
github-actions
Bot
removed
the
approved
Contributor
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
TPC-H: Total hot run time: 31337 ms |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
TPC-DS: Total hot run time: 170144 ms |
| def tsoPersistConfig = sql "SHOW FRONTEND CONFIG like '%enable_tso_persist_journal%';" | ||
| try { | ||
| sql "ADMIN SET FRONTEND CONFIG ('enable_tso_persist_journal' = 'true')" | ||
| sql "ADMIN SET FRONTEND CONFIG ('experimental_enable_tso_feature' = 'true')" |
Contributor
There was a problem hiding this comment.
should move this to regression test config
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #61956
This PR support write and read path of binlog.
Write Path
delete_bitmapis calculated synchronously.delete_bitmapinside the current Rowset is copied tobinlog_delvec.Write Implementation Details
Allows GroupFlushContext to submit both
DATA_IN_GROUPandBINLOG_IN_GROUPtasks concurrently for the same SharedMemtable.Segment ID allocations for both writers are strictly synchronized during the flush phase.
So
binlog_delveccan resue tablet delete_bitmap(seq update, partial update conflict)Read Path
How to do simple test
CREATE TABLE test_row_binlog_simple ( k1 INT, v1 INT, v2 STRING ) UNIQUE KEY(k1) DISTRIBUTED BY HASH(k1) BUCKETS 1 PROPERTIES ( "replication_num" = "1", "enable_unique_key_merge_on_write" = "true", "binlog.enable" = "true", "binlog.format" = "ROW", "binlog.need_historical_value" = "true" ); INSERT INTO test_row_binlog_simple VALUES (1, 10, '10'), (2, 20, '20'); UPDATE test_row_binlog_simple SET v1 = 11, v2 = '11' WHERE k1 = 1; SELECT __DORIS_BINLOG_LSN__ DIV 18446744073709551616 AS version, __DORIS_BINLOG_LSN__ % 18446744073709551616 AS row_id, __DORIS_BINLOG_OP__ AS op, k1, v1, v2, __BEFORE__v1__, __BEFORE__v2__ FROM binlog("table" = "test_row_binlog_simple") ORDER BY __DORIS_BINLOG_LSN__;Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)