[feature](tls) Add TLS framework #63145
Open
Hastyshell wants to merge 6 commits into
Open
Conversation
### What problem does this PR solve? Issue Number: None Related PR: selectdb/selectdb-core#8598 Problem Summary: Port the public mTLS scaffolding, configuration, protocol startup split, certificate-auth contracts, and TLS validation tests while excluding all enterprise module directories. ### Release note Add TLS configuration and certificate-auth scaffolding for optional TLS modules. ### Check List (For Author) - Test: bash -n build.sh run-fe-ut.sh run-be-ut.sh run-cloud-ut.sh; git diff --check --cached; ./run-fe-ut.sh --run org.apache.doris.analysis.TlsOptionsTest (fails on existing missing edu.umd.cs.findbugs.annotations.SuppressFBWarnings for generated ImmutableFlightAuthResult) - Behavior changed: Yes, adds TLS-related configuration and startup/auth extension points. - Does this need documentation: Yes
Hastyshell
requested review from
BiteTheDDDDt,
CalvinKirs,
dataroaring,
gavinchou,
morningman,
w41ter and
zclllyybb
as code owners
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
gavinchou
changed the title
### What problem does this PR solve? Issue Number: None Related PR: apache#63145 Problem Summary: Fix clang-format and FE CheckStyle failures in the TLS scaffolding PR. ### Release note None ### Check List (For Author) - Test: ./build-support/check-format.sh with clang-format 16; cd fe && mvn clean checkstyle:check; git diff --check - Behavior changed: No - Does this need documentation: No
Collaborator
Author
|
run buildall |
### What problem does this PR solve? Issue Number: None Related PR: apache#63145 Problem Summary: Remove thirdparty brpc TLS implementation patches from the OSS scaffolding PR to keep the change focused on public extension points. ### Release note None ### Check List (For Author) - Test: git diff --check --cached - Behavior changed: No - Does this need documentation: No
Collaborator
Author
|
run buildall |
### What problem does this PR solve? Issue Number: None Related PR: apache#63145 Problem Summary: Remove cloud TLS regression cases that depend on custom TLS capabilities from the OSS scaffolding PR. ### Release note None ### Check List (For Author) - Test: git diff --check --cached - Behavior changed: No - Does this need documentation: No
Collaborator
Author
|
run buildall |
Contributor
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
### What problem does this PR solve? Issue Number: None Related PR: apache#63145 Problem Summary: Fix FE compilation by returning the resolved UserIdentity directly instead of treating it as a list. ### Release note None ### Check List (For Author) - Test: git diff --check; cd fe && mvn -pl fe-core checkstyle:check - Behavior changed: No - Does this need documentation: No
Collaborator
Author
|
run buildall |
Contributor
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
### What problem does this PR solve? Issue Number: None Related PR: apache#63145 Problem Summary: Align the TlsOptions test expectation with SanEntryCodec normalization, which canonicalizes SAN types and strips trailing dots without changing value case. ### Release note None ### Check List (For Author) - Test: git diff --check; cd fe && mvn -pl fe-core checkstyle:check - Behavior changed: No - Does this need documentation: No
Contributor
TPC-H: Total hot run time: 29842 ms |
Contributor
TPC-DS: Total hot run time: 170568 ms |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE Regression Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: Port the public mTLS scaffolding, configuration, protocol startup split, certificate-auth contracts, and TLS validation tests while excluding all enterprise module directories.
Release note
Add TLS configuration and certificate-auth scaffolding for optional TLS modules.
Check List (For Author)
Test: bash -n build.sh run-fe-ut.sh run-be-ut.sh run-cloud-ut.sh; git diff --check --cached; ./run-fe-ut.sh --run org.apache.doris.analysis.TlsOptionsTest (fails on existing missing edu.umd.cs.findbugs.annotations.SuppressFBWarnings for generated ImmutableFlightAuthResult)
Behavior changed: Yes, adds TLS-related configuration and startup/auth extension points.
Does this need documentation: Yes
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)