-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[fix](fe) Fix simple aggregate cache after partition recycle #63175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91 changes: 91 additions & 0 deletions
91
...nereids_rules_p0/rewrite_simple_agg_to_constant/auto_partition_recycle_count_cache.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| suite("auto_partition_recycle_count_cache", "nonConcurrent") { | ||
| def oldCheckInterval = getFeConfig("dynamic_partition_check_interval_seconds") | ||
|
|
||
| try { | ||
| sql "SET enable_nereids_planner=true" | ||
| sql "SET enable_fallback_to_original_planner=false" | ||
| sql "DROP TABLE IF EXISTS auto_partition_recycle_count_cache FORCE" | ||
| sql """ | ||
| CREATE TABLE auto_partition_recycle_count_cache ( | ||
| k0 DATETIME(6) NOT NULL | ||
| ) ENGINE=OLAP | ||
| DUPLICATE KEY(k0) | ||
| AUTO PARTITION BY RANGE(date_trunc(k0, 'day')) () | ||
| DISTRIBUTED BY HASH(k0) BUCKETS 1 | ||
| PROPERTIES ( | ||
| "replication_num" = "1", | ||
| "partition.retention_count" = "3" | ||
| ) | ||
| """ | ||
|
|
||
| sql """ | ||
| INSERT INTO auto_partition_recycle_count_cache VALUES | ||
| ('2020-01-01 00:00:00'), | ||
| ('2020-01-02 00:00:00'), | ||
| ('2020-01-03 00:00:00'), | ||
| ('2020-01-04 00:00:00'), | ||
| ('2020-01-05 00:00:00'), | ||
| ('2020-01-06 00:00:00') | ||
| """ | ||
| sql "sync" | ||
|
|
||
| def partitionCount = sql "SHOW PARTITIONS FROM auto_partition_recycle_count_cache" | ||
| assertEquals(6, partitionCount.size()) | ||
|
|
||
| sql "SELECT count(*) FROM auto_partition_recycle_count_cache" | ||
| def cacheReady = false | ||
| for (int i = 0; i < 30; i++) { | ||
| def explainResult = sql "EXPLAIN SELECT count(*) FROM auto_partition_recycle_count_cache" | ||
| if (explainResult.toString().contains("constant exprs")) { | ||
| cacheReady = true | ||
| break | ||
| } | ||
| sleep(1000) | ||
| } | ||
| if (!cacheReady) { | ||
| if (isCloudMode()) { | ||
| logger.info("SimpleAggCacheMgr did not warm up in cloud mode, skip") | ||
| return | ||
| } | ||
| assertTrue(false, "SimpleAggCacheMgr cache did not warm up within 30 seconds") | ||
| } | ||
|
|
||
| def countBeforeRecycle = sql "SELECT count(*) FROM auto_partition_recycle_count_cache" | ||
| assertEquals(6L, countBeforeRecycle[0][0] as long) | ||
|
|
||
| setFeConfig("dynamic_partition_check_interval_seconds", 1) | ||
| def recycled = false | ||
| for (int i = 0; i < 30; i++) { | ||
| partitionCount = sql "SHOW PARTITIONS FROM auto_partition_recycle_count_cache" | ||
| if (partitionCount.size() == 3) { | ||
| recycled = true | ||
| break | ||
| } | ||
| sleep(1000) | ||
| } | ||
| assertTrue(recycled, "auto partition retention did not recycle partitions within 30 seconds") | ||
|
|
||
| def countAfterRecycle = sql "SELECT count(*) FROM auto_partition_recycle_count_cache" | ||
| assertEquals(3L, countAfterRecycle[0][0] as long) | ||
| } finally { | ||
| setFeConfig("dynamic_partition_check_interval_seconds", oldCheckInterval) | ||
| sql "DROP TABLE IF EXISTS auto_partition_recycle_count_cache FORCE" | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what will happen if we query on temp partition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
对temp partition的count() 不会被记录到缓存中,也不会被应用到 select count() from t; 上。
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/RewriteSimpleAggToConstantRule.java 的tryRewrite() 函数里会检查是否有指定分区。如果指定分区就不rewrite