branch-4.1: [fix](load) rebuild broker load storage properties after Gson replay #63094#63177
Merged
Merged
Conversation
…63094) ### What problem does this PR solve? Problem Summary: Broker load jobs may fail after FE restart, image load, or edit log replay in cloud mode. `StorageDesc.storageProperties` is not persisted by Doris's Gson configuration, so after deserialization the `BrokerDesc` inside `BrokerLoadJob` can keep `storageType` and raw `properties` but lose the derived `storageProperties` object. When the pending task later tries to create a filesystem and list source files, FE cannot reconstruct the expected storage backend state and the load may fail with errors such as `Unknown storage type`. This PR fixes the issue by rebuilding `storageProperties` from `storageType`, `name`, and `properties` after Gson replay, and also lazily reinitializing it on access as a safety net.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
|
skip buildall |
yiguolei
approved these changes
May 13, 2026
github-actions
Bot
added
the
approved
Contributor
Author
|
PR approved by at least one committer and no changes requested. |
Contributor
Author
|
PR approved by anyone and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #63094