branch-4.0: [fix](fe) Fix Type.exceedsMaxNestingDepth skipping MAP keyType recursion #63201#63212
Merged
Merged
Conversation
…ion (#63201) ## Summary `Type.exceedsMaxNestingDepth` in the MAP branch only recursed into `valueType` and silently skipped `keyType`. A user could construct arbitrarily deep types via the MAP key path, bypassing the 9-layer nesting limit. ### What problem does this PR solve? Problem Summary: ```java // Before fix — MAP branch: } else if (isMapType()) { MapType mapType = (MapType) this; return mapType.getValueType().exceedsMaxNestingDepth(d + 1); // keyType never checked } ``` ARRAY and STRUCT branches recursed correctly; only MAP missed the keyType path. ### Fix ```java } else if (isMapType()) { MapType mapType = (MapType) this; if (mapType.getKeyType().exceedsMaxNestingDepth(d + 1)) { return true; } return mapType.getValueType().exceedsMaxNestingDepth(d + 1); } ``` ### Tests Three new FE unit tests added to `TypeTest`: - `testMapKeyPathNestingWithinLimit` — `MAX_NESTING_DEPTH` levels via keyType → allowed (assertFalse) - `testMapKeyPathDeepNestingDetected` — `MAX_NESTING_DEPTH + 1` levels via keyType → rejected (assertTrue) - `testMapValuePathDeepNestingDetected` — regression guard: valueType path still detected (assertTrue) All 11 tests in `TypeTest` pass. ### Release note Fix MAP key-type nesting-depth check bypass: deeply-nested MAP key types are now correctly rejected with "Type exceeds the maximum nesting depth". Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
morningman
approved these changes
May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #63201