[fix](function) prevent count_substrings tail overmatch#63215
Open
officialasishkumar wants to merge 1 commit into
Open
[fix](function) prevent count_substrings tail overmatch#63215officialasishkumar wants to merge 1 commit into
officialasishkumar wants to merge 1 commit into
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #62768
Related PR: None
Problem Summary:
count_substringsscanned candidate positions even when the remaining suffix was shorter than the search pattern. Because the implementation usesmemcmp_small_allow_overflow15, that could count a tail position where the full pattern does not fit, for examplecount_substrings("ccc", "cc").This PR limits comparisons to positions where the full pattern fits and keeps the existing not-found distance contract used by the caller.
Release note
Fix
count_substringstail-boundary matching for non-overlapping substring counts.Check List (For Author)
Test
Behavior changed:
count_substringsno longer counts a match when the full pattern does not fit in the remaining suffix.Does this need documentation?
Check List (For Reviewer who merge this PR)