[fix](fe) Allow show tablet without selected database#63280
Open
englefly wants to merge 1 commit into
Open
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 30936 ms |
Contributor
TPC-DS: Total hot run time: 169307 ms |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
Author
|
run p0 |
Contributor
Author
|
run cloud_p0 |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Issue Number: None
Related PR: None
Problem Summary: SHOW TABLET <tablet_id> looked up tablet metadata by id but still required a selected session database during validation. This caused No database selected when the mysql client had not executed USE <db>, even though the command can resolve the owning database from TabletMeta.
None
- Test: Regression test / Unit Test
- tools/fast-compile-fe.sh fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/ShowTabletIdCommand.java
- tools/fast-compile-fe.sh --test fe/fe-core/src/test/java/org/apache/doris/nereids/trees/plans/commands/ShowTabletIdCommandTest.java
- ./run-regression-test.sh --run -d show_p0 -s test_show_tablet
- cd fe && mvn checkstyle:check -pl fe-core -Dcheckstyle.includes='**/ShowTabletIdCommand.java,**/ShowTabletIdCommandTest.java'
- Manual test: mysql -h :: -u root -P 29031 -e 'show tablet 1778657405980;'
- Behavior changed: Yes. SHOW TABLET <tablet_id> no longer requires a selected database.
Contributor
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 30891 ms |
Contributor
TPC-DS: Total hot run time: 169945 ms |
Contributor
FE UT Coverage ReportIncrement line coverage `` 🎉 |
Contributor
FE Regression Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary: SHOW TABLET <tablet_id> looked up tablet metadata by id but still required a selected session database during validation. This caused No database selected when the mysql client had not executed USE , even though the command can resolve the owning database from TabletMeta.
Issue Number: close #xxx
Related PR: #48815
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)