branch-4.1: [fix](be) Move partitioned agg shared cleanup to shared state #63253#63287
Open
github-actions[bot] wants to merge 1 commit into
Open
branch-4.1: [fix](be) Move partitioned agg shared cleanup to shared state #63253#63287github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: Partitioned aggregation source close cleaned a shared
state owned by both sink and source pipelines. This could make shared
spill cleanup depend on a local source operator lifecycle even though
the state is shared. This PR moves leftover spill file cleanup to
`PartitionedAggSharedState` itself and makes `close()` idempotent.
### Release note
None
### Check List (For Author)
- Test: Manual test
- `build-support/clang-format.sh`
- `build-support/check-format.sh`
- `git diff --check`
- Behavior changed: No
- Does this need documentation: No
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Member
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
Author
There was a problem hiding this comment.
Summary: I did not find any critical blocking issues in this PR. The cleanup ownership move from the source operator close path to PartitionedAggSharedState lifetime is consistent with the shared ownership model, and the CAS guard makes close() idempotent for concurrent/repeated calls. The source-local queue still owns files after they are moved out of _spill_partitions, so the existing local cleanup path remains responsible for those files.
Critical checkpoints:
- Correctness/lifecycle: No blocking issue found. Shared-state leftover spill files are cleaned at shared-state destruction, while files moved to the source local queue are still cleaned by PartitionedAggLocalState::close().
- Concurrency/idempotency: No blocking issue found. compare_exchange_strong prevents duplicate shared-state cleanup.
- Resource management: No blocking issue found in the changed paths.
- Tests/validation: git diff --check passed. I attempted build-support/check-format.sh --diff 89da166, but this runner does not have clang-format 16, so the repository format script could not run here.
- Existing review threads: none were present, so no duplicate comments were submitted.
- User focus points: no additional user-provided review focus was specified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #63253