Skip to content

branch-3.1：[fix](fe) Fix broken pipe risk on stream load redirect with unconsumed request body#63294

Open
wenzhenghu wants to merge 5 commits into
apache:branch-3.1from
HYDCP:apache-3.1-stream-load-drain-request-body
Open

branch-3.1：[fix](fe) Fix broken pipe risk on stream load redirect with unconsumed request body#63294
wenzhenghu wants to merge 5 commits into
apache:branch-3.1from
HYDCP:apache-3.1-stream-load-drain-request-body

Conversation

@wenzhenghu
Copy link
Copy Markdown
Contributor

@wenzhenghu wenzhenghu commented May 15, 2026

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@wenzhenghu wenzhenghu requested a review from morrySnow as a code owner May 15, 2026 08:53
@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented May 15, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wenzhenghu wenzhenghu changed the title [fix](fe) Fix broken pipe risk on stream load redirect with unconsumed request body [draft][fix](fe) Fix broken pipe risk on stream load redirect with unconsumed request body May 15, 2026
@wenzhenghu
Copy link
Copy Markdown
Contributor Author

wenzhenghu commented May 15, 2026

run buildall

@wenzhenghu
Copy link
Copy Markdown
Contributor Author

wenzhenghu commented May 15, 2026

/review

@wenzhenghu
[fix](http) add missing uri import for redirect url build
bc262eb 
Add the missing java.net.URI import to fix FE compilation in RestBaseController.
@wenzhenghu
Copy link
Copy Markdown
Contributor Author

wenzhenghu commented May 16, 2026

run buildall

@wenzhenghu
[fix](stream-load) improve redirect drain handling and tests
9614e0d 
Handle IOException in stream load forward redirect response generation.

Use a bounded idle time window for redirect drain and add delayed-arrival regression coverage.
@wenzhenghu
Copy link
Copy Markdown
Contributor Author

wenzhenghu commented May 17, 2026

run buildall

@wenzhenghu
[fix](stream-load) fix redirect view test compatibility
16d3c25 
Remove the RedirectView status getter assertion from LoadActionTest because the current Spring version does not expose getStatusCode().
@wenzhenghu
Copy link
Copy Markdown
Contributor Author

wenzhenghu commented May 17, 2026

run buildall

@wenzhenghu
Copy link
Copy Markdown
Contributor Author

wenzhenghu commented May 17, 2026

/review

@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented May 17, 2026

FE UT Coverage Report

Increment line coverage 64.29% (72/112) 🎉
Increment coverage report
Complete coverage report

@wenzhenghu
Copy link
Copy Markdown
Contributor Author

wenzhenghu commented May 17, 2026

run buildall

1 similar comment
@wenzhenghu
Copy link
Copy Markdown
Contributor Author

wenzhenghu commented May 17, 2026

run buildall

@wenzhenghu
[fix](stream-load) make redirect drain idle wait configurable
b6d0cce 
Add a configurable idle wait window for stream load redirect drain.

Refactor the repeated idle wait path, return INTERRUPTED on sleep interruption, and update FE unit tests accordingly.
@wenzhenghu
Copy link
Copy Markdown
Contributor Author

wenzhenghu commented May 17, 2026

run buildall

@wenzhenghu
Copy link
Copy Markdown
Contributor Author

wenzhenghu commented May 17, 2026

#63325

@wenzhenghu wenzhenghu changed the title [draft][fix](fe) Fix broken pipe risk on stream load redirect with unconsumed request body [fix](fe) Fix broken pipe risk on stream load redirect with unconsumed request body May 17, 2026
@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented May 17, 2026

FE UT Coverage Report

Increment line coverage 70.94% (83/117) 🎉
Increment coverage report
Complete coverage report

@wenzhenghu
Copy link
Copy Markdown
Contributor Author

wenzhenghu commented May 18, 2026

/review

@wenzhenghu wenzhenghu changed the title [fix](fe) Fix broken pipe risk on stream load redirect with unconsumed request body branch-3.1：[fix](fe) Fix broken pipe risk on stream load redirect with unconsumed request body May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow Awaiting requested review from morrySnow morrySnow is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wenzhenghu @hello-stephen