[fix](testcase) Fix wrong test case#63354
Merged
Merged
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
Author
|
/review |
Contributor
There was a problem hiding this comment.
Automated review summary:
No blocking issues found in this PR. The change is limited to negative regression-test queries for malformed parquet inputs, and removing LIMIT 10 is consistent with forcing the scan to reach the malformed data so the expected exception is actually exercised.
Critical checkpoint conclusions:
- Goal/test proof: The PR appears to fix incorrect negative test coverage for two parquet files; the modified tests use the existing
test { sql; exception }pattern. - Scope: The modification is small and focused, with only two query text changes.
- Concurrency/lifecycle/config/compatibility: Not applicable; this is regression test SQL only.
- Parallel paths: Both similar malformed parquet negative cases in this file were updated.
- Test coverage: Existing regression test coverage is adjusted; I did not run it locally because it depends on the external Hive/HDFS test environment.
- Test result correctness: No
.outchanges are required for exception tests. - Observability/transactions/data writes/FE-BE variable passing/performance: Not applicable to this test-only change.
- User focus: No additional user-provided review focus was present.
Residual risk: The exact exception behavior is environment/data dependent and should be validated by the external table regression job.
Mryange
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)