Skip to content

[fix](testcase) Fix wrong test case#63354

Merged
Gabriel39 merged 1 commit into
apache:masterfrom
Gabriel39:fix_0518
May 19, 2026
Merged

[fix](testcase) Fix wrong test case#63354
Gabriel39 merged 1 commit into
apache:masterfrom
Gabriel39:fix_0518

Conversation

@Gabriel39
Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Gabriel39
Copy link
Copy Markdown
Contributor Author

run buildall

@Gabriel39
Copy link
Copy Markdown
Contributor Author

/review

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review summary:

No blocking issues found in this PR. The change is limited to negative regression-test queries for malformed parquet inputs, and removing LIMIT 10 is consistent with forcing the scan to reach the malformed data so the expected exception is actually exercised.

Critical checkpoint conclusions:

  • Goal/test proof: The PR appears to fix incorrect negative test coverage for two parquet files; the modified tests use the existing test { sql; exception } pattern.
  • Scope: The modification is small and focused, with only two query text changes.
  • Concurrency/lifecycle/config/compatibility: Not applicable; this is regression test SQL only.
  • Parallel paths: Both similar malformed parquet negative cases in this file were updated.
  • Test coverage: Existing regression test coverage is adjusted; I did not run it locally because it depends on the external Hive/HDFS test environment.
  • Test result correctness: No .out changes are required for exception tests.
  • Observability/transactions/data writes/FE-BE variable passing/performance: Not applicable to this test-only change.
  • User focus: No additional user-provided review focus was present.

Residual risk: The exact exception behavior is environment/data dependent and should be validated by the external table regression job.

@Gabriel39 Gabriel39 merged commit ea93318 into apache:master May 19, 2026
34 checks passed
github-actions Bot pushed a commit that referenced this pull request May 19, 2026
github-actions Bot pushed a commit that referenced this pull request May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants