Skip to content

[fix](docker) allow overriding fdb image#63393

Merged
gavinchou merged 1 commit into
apache:masterfrom
bobhan1:specify-fdb-image
May 19, 2026
Merged

[fix](docker) allow overriding fdb image#63393
gavinchou merged 1 commit into
apache:masterfrom
bobhan1:specify-fdb-image

Conversation

@bobhan1
Copy link
Copy Markdown
Contributor

@bobhan1 bobhan1 commented May 19, 2026

Add an --fdb-image option to doris-compose up, with DORIS_FDB_IMAGE as the environment-variable default. This lets docker regression cases use a locally derived FoundationDB image while preserving the existing --fdb-version based default image when no override is provided.

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

Add an --fdb-image option to doris-compose up, with DORIS_FDB_IMAGE as the environment-variable default. This lets docker regression cases use a locally derived FoundationDB image while preserving the existing --fdb-version based default image when no override is provided.

Validation: env -u HTTP_PROXY -u HTTPS_PROXY -u http_proxy -u https_proxy -u ALL_PROXY -u all_proxy DORIS_FDB_IMAGE=foundationdb/foundationdb:7.1.26-baohan-flat ./run-regression-test.sh --run -d regression-test/suites/cloud_p0/cache/write_index_only -runMode=cloud
@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@gavinchou
Copy link
Copy Markdown
Contributor

run buildall

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label May 19, 2026
@github-actions
Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@bobhan1
Copy link
Copy Markdown
Contributor Author

bobhan1 commented May 19, 2026

/review

@gavinchou gavinchou merged commit 0338e0e into apache:master May 19, 2026
34 checks passed
github-actions Bot pushed a commit that referenced this pull request May 20, 2026
Add an --fdb-image option to doris-compose up, with DORIS_FDB_IMAGE as the environment-variable default. This lets docker regression cases use a locally derived FoundationDB image while preserving the existing --fdb-version based default image when no override is provided.
github-actions Bot pushed a commit that referenced this pull request May 20, 2026
Add an --fdb-image option to doris-compose up, with DORIS_FDB_IMAGE as the environment-variable default. This lets docker regression cases use a locally derived FoundationDB image while preserving the existing --fdb-version based default image when no override is provided.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.x dev/4.1.x reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants