branch-4.0: [fix](fe) Preserve narrowing datetimev2 casts in simplify in predicate #63343#63420
Open
github-actions[bot] wants to merge 1 commit into
Open
branch-4.0: [fix](fe) Preserve narrowing datetimev2 casts in simplify in predicate #63343#63420github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
#63343) ### What problem does this PR solve? SimplifyInPredicate could incorrectly remove narrowing DATETIMEV2 casts inside IN predicates. For expressions such as `CAST(datetimev2(6) AS DATETIMEV2(3)) IN (...)`, the rewrite could turn the predicate into a direct comparison on the original DATETIMEV2(6) column, which is not semantics-preserving because the cast uses precision reduction and rounding. The rule also used a binary-based microsecond alignment check instead of a decimal scale check, which could incorrectly treat some literals as losslessly convertible. This change restricts the rewrite to non-narrowing DATETIMEV2 casts and fixes the literal alignment check to use decimal scale factors. It also adds FE unit tests and a regression case for the reported DATETIMEV2 scenario.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #63343