branch-4.0: [fix](nereids) Fix pre-aggregation context leakage across join branches #63357#63432
Open
github-actions[bot] wants to merge 1 commit into
Open
branch-4.0: [fix](nereids) Fix pre-aggregation context leakage across join branches #63357#63432github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…es (#63357) ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: for agg_keys tables, Nereids may incorrectly set PREAGGREGATION: ON for a normal scan in a join when the other join branch contains an aggregate subquery. example sql ``` select cw.term_id, cw.class_id, cw.original_num, cw.abs_week from repro_preagg_join cw join ( select term_id, class_id, max(abs_week) as abs_week from repro_preagg_join where class_id in (10192497, 10192366) group by term_id, class_id ) mw on cw.class_id = mw.class_id and cw.abs_week = mw.abs_week; ``` root cause: 1. If repro_preagg_join is an AGGREGATE KEY table and the same key exists in multiple rowsets, the left scan cw should merge rows before returning data. However, before this fix, the plan could mark the left scan as: "PREAGGREGATION: ON " 2. This makes be read the underlying rows directly without merging, so duplicated physical rows from multiple rowsets can be returned and then joined, producing duplicated query results. 3. The right aggregate subquery itself is not duplicated. The wrong result is caused by the left sibling scan being incorrectly affected by the aggregate context from the right branch. ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #63357