Skip to content

branch-4.1: [fix](user_var)fix integer typing and prefer Variable.realExpression for argument/type resolution#62524#63452

Merged
yiguolei merged 1 commit into
apache:branch-4.1from
starocean999:b41_0521
May 21, 2026
Merged

branch-4.1: [fix](user_var)fix integer typing and prefer Variable.realExpression for argument/type resolution#62524#63452
yiguolei merged 1 commit into
apache:branch-4.1from
starocean999:b41_0521

Conversation

@starocean999
Copy link
Copy Markdown
Contributor

pick #62524

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

…for argument/type resolution (apache#62524)

PR fixes two bugs:
(1) user/session variable integer typing was wrong when converted to
Nereids literals;
(2) Ensure ExpressionTrait resolves argument expressions and types from
a Variable's real expression when present, and falls back to the
Variable itself when not. This prevents generating incorrect function
signatures using Variable placeholders.
@starocean999 starocean999 requested a review from yiguolei as a code owner May 21, 2026 02:50
@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@starocean999
Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen
Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 26.52% (35/132) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 66.20% (94/142) 🎉
Increment coverage report
Complete coverage report

@yiguolei yiguolei merged commit 3aa1967 into apache:branch-4.1 May 21, 2026
29 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants