Skip to content

branch-4.0: pick some PRs about aggregate functions #63457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zclllyybb wants to merge 2 commits into
base: branch-4.0
Choose a base branch
from
Open

branch-4.0: pick some PRs about aggregate functions #63457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3b1587
[enhance](agg) Support max/min agg functions for type_array (#58490)
wumeibanfa Dec 3, 2025
08822a6
[enhance](agg) Support max_by/min_by agg functions for some complex t…
wumeibanfa Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 0 additions & 32 deletions be/src/vec/aggregate_functions/aggregate_function_max_by.cpp
View file
Open in desktop

This file was deleted.

32 changes: 0 additions & 32 deletions be/src/vec/aggregate_functions/aggregate_function_min_by.cpp
View file
Open in desktop

This file was deleted.

40 changes: 12 additions & 28 deletions be/src/vec/aggregate_functions/aggregate_function_min_max.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,35 +134,20 @@ AggregateFunctionPtr create_aggregate_function_single_value(const String& name,
return creator_without_type::create_unary_arguments<
AggregateFunctionsSingleValue<Data<SingleValueDataDecimal<TYPE_DECIMAL256>>>>(
argument_types, result_is_nullable, attr);
default:
return nullptr;
}
}

// any_value
template <template <typename> class Data>
AggregateFunctionPtr create_aggregate_function_single_value_any_value_function(
const String& name, const DataTypes& argument_types, const DataTypePtr& result_type,
const bool result_is_nullable, const AggregateFunctionAttr& attr) {
AggregateFunctionPtr res = create_aggregate_function_single_value<Data>(
name, argument_types, result_type, result_is_nullable, attr);
if (res) {
return res;
}
const DataTypePtr& argument_type = remove_nullable(argument_types[0]);
if (argument_type->get_primitive_type() == PrimitiveType::TYPE_ARRAY ||
argument_type->get_primitive_type() == PrimitiveType::TYPE_MAP ||
argument_type->get_primitive_type() == PrimitiveType::TYPE_STRUCT ||
argument_type->get_primitive_type() == PrimitiveType::TYPE_AGG_STATE ||
argument_type->get_primitive_type() == PrimitiveType::TYPE_BITMAP ||
argument_type->get_primitive_type() == PrimitiveType::TYPE_HLL ||
argument_type->get_primitive_type() == PrimitiveType::TYPE_QUANTILE_STATE) {
// For Complex type. Currently, only type_array supports min and max.
case PrimitiveType::TYPE_ARRAY:
case PrimitiveType::TYPE_MAP:
case PrimitiveType::TYPE_STRUCT:
case PrimitiveType::TYPE_AGG_STATE:
case PrimitiveType::TYPE_BITMAP:
case PrimitiveType::TYPE_HLL:
case PrimitiveType::TYPE_QUANTILE_STATE:
return creator_without_type::create_unary_arguments<
AggregateFunctionsSingleValue<SingleValueDataComplexType>>(
AggregateFunctionsSingleValue<Data<SingleValueDataComplexType>>>(
argument_types, result_is_nullable, attr);
default:
return nullptr;
}

return nullptr;
}

void register_aggregate_function_minmax(AggregateFunctionSimpleFactory& factory) {
Expand All @@ -171,8 +156,7 @@ void register_aggregate_function_minmax(AggregateFunctionSimpleFactory& factory)
factory.register_function_both(
"min", create_aggregate_function_single_value<AggregateFunctionMinData>);
factory.register_function_both(
"any",
create_aggregate_function_single_value_any_value_function<AggregateFunctionAnyData>);
"any", create_aggregate_function_single_value<AggregateFunctionAnyData>);
factory.register_alias("any", "any_value");
}

Expand Down
Loading
Loading