branch-4.1: [fix](streaming-job) Avoid NPE on cross-table DML during snapshot chunk read #63435#63503
Merged
Merged
Conversation
…nk read (#63435) ### What problem does this PR solve? During the snapshot phase, the chunk reader (`IncrementalSourceScanFetcher`) consumes from a change-event queue that may also contain DML records from **other tables** being captured concurrently. When such a foreign-table record reached `isChangeRecordInChunkRange`, the code compared it against the **current chunk's** PK range via `isRecordBetween(...)`. Two problems: 1. The foreign table's schema may not yet be loaded for this fetcher, so extracting its PK throws NPE. 2. Even if the schema were loaded, the foreign table's PK columns do not necessarily align with this chunk's bounds, so any range comparison is meaningless and the record would be incorrectly merged into the wrong chunk's output buffer. This patch adds an explicit `TableId` check at the very start of `isChangeRecordInChunkRange`: records whose `TableId` does not match `currentSnapshotSplit.getTableId()` are skipped before any PK-based comparison runs.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
yiguolei
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #63435