branch-4.1: [fix](fe) add --drop_backends param to start_fe.sh (#63306)#63515
Merged
Conversation
This PR adds a --drop_backends startup flag for Doris FE, wiring it through bin/start_fe.sh into FE argument parsing, and executing backend removal when the FE becomes master.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR backports a new FE startup flag --drop_backends that, when enabled, triggers Doris FE to remove all backends from cluster metadata at the moment the FE becomes MASTER. It’s wired end-to-end from bin/start_fe.sh through FE argument parsing into Env.transferToMaster() (and is also enabled during the cloud recovery path in the docker compose runtime init script).
Changes:
- Add
--drop_backendsoption parsing inbin/start_fe.shand forward it toorg.apache.doris.DorisFE. - Extend FE CLI parsing (
DorisFE.parseArgs) to set a system property flag fordrop_backends. - When transferring to MASTER (
Env.transferToMaster), drop all backends (non-cloud viadropBackend, cloud viaCloudSystemInfoService.updateCloudBackends). - Enable
--drop_backendsautomatically in the cloud recovery startup path (docker/runtime/.../init_fe.sh).
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
fe/fe-core/src/main/java/org/apache/doris/DorisFE.java |
Adds the --drop_backends CLI option and sets the corresponding system property. |
fe/fe-core/src/main/java/org/apache/doris/common/FeConstants.java |
Introduces the DROP_BACKENDS_KEY constant. |
fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java |
Drops all backends during transferToMaster() when the flag is enabled. |
docker/runtime/doris-compose/resource/init_fe.sh |
Appends --drop_backends to recovery startup args in cloud compose runtime. |
bin/start_fe.sh |
Parses and forwards the new --drop_backends shell flag to FE. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1787
to
+1791
| } catch (Exception e) { | ||
| LOG.warn("failed to drop backends", e); | ||
| } | ||
| System.clearProperty(FeConstants.DROP_BACKENDS_KEY); | ||
| LOG.info("finished dropping all backends"); |
Contributor
Author
|
run buildall |
Contributor
FE Regression Coverage ReportIncrement line coverage |
yiguolei
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pick #63306