[feat](txn) Add txn write amplification brpc metrics for sub txn load#63545
Merged
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Collaborator
Author
|
run buildall |
gavinchou
approved these changes
May 25, 2026
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
|
/review |
Contributor
There was a problem hiding this comment.
Review result: no blocking issues found. The added stats recording in commit_txn_with_sub_txn is consistent with the existing commit_txn_immediately and commit_txn_eventually call sites and occurs after pending lazy commits are advanced, before the commit mutation is built.
Critical checkpoint conclusions:
- Goal and proof: Goal appears to be adding txn commit count metrics for sub-txn load; the code accomplishes this by invoking the existing recorder on the sub-txn path. No new test is included; acceptable for this observability-only addition, but CI/build coverage should still compile the cloud target.
- Scope: Change is small and focused.
- Concurrency/lifecycle: No new shared state or lifecycle management is introduced beyond existing bvar recorders.
- Config/compatibility/protocol: No new config, storage format, RPC schema, or compatibility behavior.
- Parallel paths: The sub-txn path now matches the existing immediate/eventual commit paths.
- Error handling/data correctness/MoW: No commit control flow, transaction state, version visibility, or MoW metadata logic is changed.
- Testing: No PR test evidence provided; risk is limited to compile/runtime observability because this is a metrics-only call.
- Observability: Improves coverage for sub-txn commit metrics.
- User focus: No additional user-provided review focus.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)