Skip to content

[feat](txn) Add txn write amplification brpc metrics for sub txn load#63545

Merged
gavinchou merged 1 commit into
apache:masterfrom
wyxxxcat:record_mow_tbl_wa
May 25, 2026
Merged

[feat](txn) Add txn write amplification brpc metrics for sub txn load#63545
gavinchou merged 1 commit into
apache:masterfrom
wyxxxcat:record_mow_tbl_wa

Conversation

@wyxxxcat
Copy link
Copy Markdown
Collaborator

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wyxxxcat
Copy link
Copy Markdown
Collaborator Author

run buildall

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label May 25, 2026
@github-actions
Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@gavinchou
Copy link
Copy Markdown
Contributor

/review

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review result: no blocking issues found. The added stats recording in commit_txn_with_sub_txn is consistent with the existing commit_txn_immediately and commit_txn_eventually call sites and occurs after pending lazy commits are advanced, before the commit mutation is built.

Critical checkpoint conclusions:

  • Goal and proof: Goal appears to be adding txn commit count metrics for sub-txn load; the code accomplishes this by invoking the existing recorder on the sub-txn path. No new test is included; acceptable for this observability-only addition, but CI/build coverage should still compile the cloud target.
  • Scope: Change is small and focused.
  • Concurrency/lifecycle: No new shared state or lifecycle management is introduced beyond existing bvar recorders.
  • Config/compatibility/protocol: No new config, storage format, RPC schema, or compatibility behavior.
  • Parallel paths: The sub-txn path now matches the existing immediate/eventual commit paths.
  • Error handling/data correctness/MoW: No commit control flow, transaction state, version visibility, or MoW metadata logic is changed.
  • Testing: No PR test evidence provided; risk is limited to compile/runtime observability because this is a metrics-only call.
  • Observability: Improves coverage for sub-txn commit metrics.
  • User focus: No additional user-provided review focus.

@gavinchou gavinchou merged commit 60d1b99 into apache:master May 25, 2026
33 checks passed
yiguolei pushed a commit that referenced this pull request May 25, 2026
…sub txn load #63545 (#63590)

Cherry-picked from #63545

Co-authored-by: Yixuan Wang <wangyixuan@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.x dev/4.1.2-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants