[fix](nereids) abort SimplifyArithmeticComparison rewrite when the ne…#63567
Open
yx-keith wants to merge 1 commit into
Open
[fix](nereids) abort SimplifyArithmeticComparison rewrite when the ne…#63567yx-keith wants to merge 1 commit into
yx-keith wants to merge 1 commit into
Conversation
…w constant overflows (apache#61761) date_sub(i, interval 1 day) <= '9999-12-31' was being rewritten to i <= days_add('9999-12-31', 1). The new constant overflows the DATE domain, but the rule did not detect this: FoldConstantRule.evaluate swallows exceptions in non-debug mode and returns the unfolded expression, so the overflow leaked to runtime as "Operation day_add of 9999-12-31 00:00:00, 1 out of range". Eagerly fold the rearranged constant inside tryRearrangeChildren when both sides are literals. A non-Literal result means folding failed, in which case we throw so the outer try/catch falls back to the original comparison. This covers the symmetric overflow case for every operator pair in REARRANGEMENT_MAP (days/weeks/hours/minutes/ seconds + numeric add/sub/divide). Also add unit tests for the date overflow cases and a regression test based on the original repro.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 31344 ms |
Contributor
TPC-DS: Total hot run time: 174911 ms |
Contributor
FE Regression Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…w constant overflows (#61761)
date_sub(i, interval 1 day) <= '9999-12-31' was being rewritten to i <= days_add('9999-12-31', 1). The new constant overflows the DATE domain, but the rule did not detect this: FoldConstantRule.evaluate swallows exceptions in non-debug mode and returns the unfolded expression, so the overflow leaked to runtime as
"Operation day_add of 9999-12-31 00:00:00, 1 out of range".
Eagerly fold the rearranged constant inside tryRearrangeChildren when both sides are literals. A non-Literal result means folding failed, in which case we throw so the outer try/catch falls back to the original comparison. This covers the symmetric overflow case for every operator pair in REARRANGEMENT_MAP (days/weeks/hours/minutes/ seconds + numeric add/sub/divide).
Also add unit tests for the date overflow cases and a regression test based on the original repro.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)