Skip to content

[chore](build) Ignore local IDE metadata files#63572

Merged
morrySnow merged 1 commit into
apache:masterfrom
yujun777:ignore-factory-path
May 25, 2026
Merged

[chore](build) Ignore local IDE metadata files#63572
morrySnow merged 1 commit into
apache:masterfrom
yujun777:ignore-factory-path

Conversation

@yujun777
Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary: nvim-jdtls generates a local .factorypath file and worktree setup creates .worktree_initialized. These files are local metadata and should not appear as untracked working tree changes.

Release note

None

Check List (For Author)

  • Test: No need to test (gitignore-only change)
  • Behavior changed: No
  • Does this need documentation: No

Ignore files generated by nvim-jdtls and local worktree setup so they do not appear as untracked working tree changes.

Key changes:
- Ignore .factorypath generated by nvim-jdtls
- Ignore .worktree_initialized generated by worktree setup

Unit Test:
- Not run, gitignore-only change
@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@yujun777
Copy link
Copy Markdown
Contributor Author

run buildall

@morrySnow
Copy link
Copy Markdown
Contributor

/review

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label May 25, 2026
@github-actions
Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review result: no blocking issues found.

Critical checkpoint conclusions:

  • Goal/test: The PR aims to ignore local IDE/worktree marker files. The .gitignore additions accomplish that; no runtime test is needed for a gitignore-only change.
  • Scope: The actual GitHub PR diff is small and focused on .gitignore only.
  • Concurrency/lifecycle/config/compatibility/data writes/transactions/FE-BE protocol: Not applicable.
  • Parallel paths: No similar required path was missed for this gitignore-only change.
  • Special checks/observability/performance: Not applicable.
  • Test coverage/results: No tests were run, which is acceptable for this metadata-only ignore rule.
  • User focus: No additional user-provided review focus was present.

@morrySnow morrySnow merged commit fac0cbb into apache:master May 25, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants