Skip to content

[chore](regression-test) make test_point_query_ck nonConcurrent #63587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eldenmoon merged 1 commit into from
May 25, 2026
+1 −1
Merged

[chore](regression-test) make test_point_query_ck nonConcurrent #63587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion regression-test/suites/point_query_p0/test_point_query_ck.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

import java.math.BigDecimal;

suite("test_point_query_ck") {
suite("test_point_query_ck", "nonConcurrent") {
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot May 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only moves test_point_query_ck into the nonConcurrent phase, but the sibling regression-test/suites/point_query_p0/test_point_query.groovy suite is still declared as suite("test_point_query"). That suite also mutates process-wide FE state (ADMIN SET FRONTEND CONFIG ("enable_lightweight_lookup_request" = ...)), and the regression framework runs NORMAL suites concurrently before SINGLE suites (RegressionTest.runScripts waits for NORMAL futures before running GroupExecType.SINGLE). So this PR prevents test_point_query_ck from overlapping with normal suites, but test_point_query can still overlap with other normal suites and cause the same class of global-config interference that the PR title says should be fixed. Please mark test_point_query as nonConcurrent too, or otherwise explain why only the CK variant needs serialization.

def backendId_to_backendIP = [:]
def backendId_to_backendHttpPort = [:]
getBackendIpHttpPort(backendId_to_backendIP, backendId_to_backendHttpPort);
Expand Down
Loading