[chore](beut) fix beut use assume_mutable#63598
Merged
Merged
Conversation
Contributor
Author
|
run buildall |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
TPC-H: Total hot run time: 31484 ms |
Contributor
TPC-DS: Total hot run time: 172519 ms |
Contributor
Author
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Automated review summary:
No blocking findings. The PR is a narrowly scoped replacement of removed assume_mutable() calls with assert_mutable() in BE array-view benchmarks/tests.
Critical checkpoints:
- Goal/test: accomplishes the build-fix goal for these benchmark/test helpers; existing
ColumnArrayViewTestcovers nullable array helper paths, but I did not run BE UT in this runner. - Scope: minimal and focused.
- COW/lifecycle:
assert_mutable()is used on freshly created local columns at the reviewed call sites; benchmark helpers retain read-only aliases after wrapping, which is safe for current read-only use. - Concurrency: none involved.
- Config/compatibility/persistence/transactions/data writes/FE-BE variables: not applicable.
- Parallel paths: all remaining
assume_mutable()references in the repo are removed. - Tests/results: no expected result files changed; no handwritten results.
- Observability/performance: not applicable; no runtime performance regression expected from these benchmark/test helper changes.
- User focus: no additional user-provided review focus; no extra issues found.
Validation performed: inspected the PR diff and relevant COW/ColumnNullable/ColumnArrayView code paths, checked existing review context, and ran git diff --check.
Contributor
Author
|
run buildall |
Contributor
Author
|
/review |
zclllyybb
approved these changes
May 25, 2026
Contributor
There was a problem hiding this comment.
Code review completed. I did not find blocking issues in this PR.
Critical checkpoint conclusions:
- Goal/test proof: The PR removes remaining
assume_mutable()usage from the changed ColumnArrayView benchmark/test code. The changed test helpers now use the sharedColumnNullable::create(ColumnPtr, ColumnPtr)path, which matches the COW API. No test execution was performed in this runner. - Scope: The modification is small and focused on the affected benchmark and BE unit-test sources.
- Concurrency/lifecycle/config/compatibility: No new concurrency, lifecycle ownership beyond existing COW column references, configuration, persistence, protocol, storage-format, or compatibility changes are introduced.
- Parallel paths: Repository search found no remaining
assume_mutableuses in C++ sources. - COW semantics: The new test-helper path avoids forcing mutable ownership when wrapping an existing column. The benchmark changes use
assert_mutable()only on freshly built local columns at current call sites, so the unique-owner precondition is satisfied. - Test coverage: Existing
ColumnArrayViewTestcoverage remains applicable, but I did not run BE UTs locally. - Observability/performance: No runtime user-facing path, logging, metric, or performance-sensitive behavior change beyond benchmark setup code.
User focus: No additional user-provided review focus was present.
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
TPC-H: Total hot run time: 31802 ms |
Contributor
TPC-DS: Total hot run time: 173146 ms |
Contributor
|
skip buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Related PR: #63386
now use assert_mutable
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)