[fix](parser) isNull should under primaryExpression#63619
Open
morrySnow wants to merge 1 commit into
Open
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
Author
|
/review |
Contributor
There was a problem hiding this comment.
Review result: no blocking issues found.
Critical checkpoint conclusions:
- Goal/test: The PR moves
ISNULL,IS_NULL_PRED, andIS_NOT_NULL_PREDfrombooleanExpressiontoprimaryExpression, which addresses precedence so expressions likeISNULL(X) = 1parse as a comparison. The added parser unit test covers the three affected forms. - Scope: The change is small and focused on grammar placement plus the corresponding visitor accessors and tests.
- Concurrency/lifecycle: Not applicable; this is parser grammar/visitor code with no shared mutable runtime state, locks, or lifecycle changes.
- Configuration/compatibility/persistence: Not applicable; no config, wire/storage format, EditLog, or transaction behavior is changed.
- Parallel paths: The visitor methods were updated consistently with the generated context shape after changing the grammar rule argument from
valueExpressiontoexpression. - Tests: Coverage is targeted to the reported precedence case for all three null-predicate spellings. I attempted to run
mvn -pl fe-core -Dtest=NereidsParserTest#testIsNullAndIsNotNullExpression -Dskip.doc=true testfromfe/, but the runner could not resolve/installorg.apache.doris:fe-foundation:jar:1.2-SNAPSHOT, so local execution was blocked by dependency setup. - Observability/performance/data correctness: Not applicable beyond parse-tree correctness; no query execution, storage visibility, memory tracking, or observability paths are touched.
User focus: no additional user-provided review focus was specified.
Contributor
TPC-H: Total hot run time: 31986 ms |
Contributor
TPC-DS: Total hot run time: 172390 ms |
Contributor
FE Regression Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
related PR #14967 #15163
Problem Summary:
The following SQL should have been executable, but it resulted in an unexpected error.
the error message is
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)