[fix](fe) Add user and role existence check in DropRowPolicyCommand#63628
Closed
heguanhui wants to merge 5 commits into
Closed
[fix](fe) Add user and role existence check in DropRowPolicyCommand#63628heguanhui wants to merge 5 commits into
heguanhui wants to merge 5 commits into
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #63322
Problem Summary: DropRowPolicyCommand does not validate whether the user or role specified in the DROP ROW POLICY statement actually exists. This is inconsistent with CreatePolicyCommand, which checks user existence via
doesUserExist()and role existence viadoesRoleExist(). Without this validation, a typo in the user or role name could silently match no policy, or the user might mistakenly believe the drop succeeded.Release note
DROP ROW POLICY now validates that the specified user and role exist, returning an error if they do not. This makes the behavior consistent with CREATE ROW POLICY.
Check List (For Author)
Check List (For Reviewer who merge this PR)