branch-4.0: [fix](regression-test) fix three muted test cases (Groovy property access + flaky SHOW PROCESSLIST)#63644
Open
morningman wants to merge 3 commits into
Conversation
…sted type create_table plugin Replace `res.size` / `res[i].size` property accesses with `res.size()` / `res[i].size()` method calls in `regression-test/plugins/plugins_create_table_nested_type.groovy`. On the Groovy runtime used by the regression framework, `java.util.ArrayList` does not expose `size` as a JavaBean property, so the property access falls through to the `getAt(Iterable, ...)` path and tries to read `.size` from each inner `Integer` element, throwing: groovy.lang.MissingPropertyException: Exception evaluating property 'size' for java.util.ArrayList, Reason: groovy.lang.MissingPropertyException: No such property: size for class: java.lang.Integer This makes the test `datatype_p0.nested_types.create_table.create_table_with_nested_type` fail in ~15 ms before any DDL is sent to FE. The test is currently muted on TeamCity (under investigation by lidongyang); this fix should unblock unmuting. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
…harset_auth
`test_show_no_auth` asserts that `SHOW PROCESSLIST` returns exactly 1 row
after granting `grant_priv` to the test user. But `ConnectPoolMgr.listConnection()`
returns *all* sessions to any caller that satisfies `PrivPredicate.ADMIN`, so
in the parallel regression pipeline this user sees the concurrent sessions of
many other suites (23 rows in the failing build).
Replace the unsafe `== 1` check with a count of sessions owned by the current
user. This aligns with the same check earlier in the file (line 49) that uses
`>= 1`, and actually verifies the intended invariant (the user can see their
own session) without depending on parallel pipeline isolation.
```diff
- assertTrue(res1.size() == 1)
+ def ownSessions = res1.findAll { it[2] == user }
+ assertTrue(ownSessions.size() >= 1)
```
Column index 2 of `SHOW PROCESSLIST` is the User column (see
`ConnectContext.ThreadInfo.toRow`).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…ache#62455) ## Problem `assertEquals(obj.data.data.size, 3)` uses `.size` without parentheses on a JSON-parsed `ArrayList<ArrayList<Integer>>`. In newer Groovy versions this triggers GPath spreading, mapping `.size` across each row element (which are `Integer`s). Since `Integer` has no `size` property: ``` groovy.lang.MissingPropertyException: No such property: size for class: java.lang.Integer ``` ## Fix ```groovy // Before assertEquals(obj.data.data.size, 3) // After assertEquals(obj.data.data.size(), 3) ``` Root cause: case issue — same GPath `.size` vs `.size()` pattern as apache#62454. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> (cherry picked from commit 50cbb9f)
morningman
changed the title
2 tasks
Contributor
Author
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bp #63645