[fix](regression) Make Iceberg rewrite where init script idempotent#63673
Open
suxiaogang223 wants to merge 1 commit into
Open
[fix](regression) Make Iceberg rewrite where init script idempotent#63673suxiaogang223 wants to merge 1 commit into
suxiaogang223 wants to merge 1 commit into
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: N/A
Problem Summary:
test_iceberg_rewrite_data_files_where_conditionsdepends on three Iceberg tables created by the Spark bootstrap scriptrun21.sql. The script usedCREATE TABLE IF NOT EXISTSand then always inserted the test rows. If the table already exists or the bootstrap SQL is re-entered after partial execution, the insert statements append data to the existing table, so the regression case may fail before runningrewrite_data_filesbecauseCOUNT(*)is no longer the expected 30 rows.This PR makes the init SQL for this case idempotent by dropping and recreating the three test tables before inserting the fixed test data.
Release note
None
Check List (For Author)
Test
git diff --check -- docker/thirdparties/docker-compose/iceberg/scripts/create_preinstalled_scripts/iceberg/run21.sqlBehavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)