branch-4.1: [opt](group-commit) Skip createLocation in group commit stream load sink #63561#63685
Open
github-actions[bot] wants to merge 1 commit into
Open
branch-4.1: [opt](group-commit) Skip createLocation in group commit stream load sink #63561#63685github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…ink (#63561) ## Summary The BE-side `GroupCommitBlockSinkOperatorX::init` does **not** consume `TOlapTableSink.location` or `slave_location` (it only reads `tuple_id` / `schema` / `db_id` / `table_id` / `partition` / `group_commit_mode` / `load_id` / `max_filter_ratio`). However, FE still runs `createLocation`, which iterates `O(partitions * indexes * tablets * replicas)` and, for every replica, takes the `CloudSystemInfoService` RW read lock via `CloudReplica.getCurrentClusterId`. Under high-concurrency group commit stream load on wide-partition tables (3000+ partitions in a real production incident), CAS contention on the RW lock's `state` cache line saturated all FE CPUs, and the cluster could not recover even after scaling out (more cores = more CAS contenders = worse contention). ## Change - Introduce a `protected initLocationParams(TOlapTableSink)` hook on `OlapTableSink`. Default behavior delegates to `createLocation`, so non-group-commit sinks are unaffected. - Route both `init(...)` overloads in `OlapTableSink` through the hook. - `GroupCommitBlockSink` overrides the hook to return empty placeholder `TOlapTableLocationParam` objects. `TOlapTableSink.location` is a required thrift field, so we still set non-null placeholders, but no tablet/replica enumeration happens. Effect on the group-commit path: - Per-request FE CPU: `O(partitions * indexes * tablets * replicas)` → `O(1)` - `CloudSystemInfoService` RW lock acquisitions: hundreds of concurrent CAS spinners → 0
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #63561