branch-4.0 [opt](fe) Bound not-null inference cost (#63318)#63688
Open
englefly wants to merge 1 commit into
Open
branch-4.0 [opt](fe) Bound not-null inference cost (#63318)#63688englefly wants to merge 1 commit into
englefly wants to merge 1 commit into
Conversation
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Not-null inference replaces candidate slots with NULL and folds each
predicate, so wide, deep, or high-slot expressions can make rewrite
rules spend excessive time in repeated replace and fold work. Aggregate
not-null inference also needed to handle multiple aggregate outputs
conservatively instead of inferring from all aggregate arguments as one
set.
This change adds a shared bounded guard for not-null inference, reuses
it from aggregate inference, and lets general callers skip only
expensive predicates while preserving the original query predicates. It
also reworks join inference to compute nullable-rejecting
slots once and reuse them for both sides, and makes aggregate inference
require a common inferred not-null predicate across supported
aggregate functions.
optimized rule:
InferAggNotNull、InferFilterNotNull、InferJoinNotNull、EliminateNotNull
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
pick #63318
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Not-null inference replaces candidate slots with NULL and folds each predicate, so wide, deep, or high-slot expressions can make rewrite rules spend excessive time in repeated replace and fold work. Aggregate not-null inference also needed to handle multiple aggregate outputs conservatively instead of inferring from all aggregate arguments as one set.
This change adds a shared bounded guard for not-null inference, reuses it from aggregate inference, and lets general callers skip only expensive predicates while preserving the original query predicates. It also reworks join inference to compute nullable-rejecting slots once and reuse them for both sides, and makes aggregate inference require a common inferred not-null predicate across supported
aggregate functions.
optimized rule:
InferAggNotNull、InferFilterNotNull、InferJoinNotNull、EliminateNotNull
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)