Skip to content

[improvement](be) Reuse table reader file block#63704

Merged
Gabriel39 merged 4 commits into
apache:refact_reader_branchfrom
Gabriel39:refactor_0526
May 27, 2026
Merged

[improvement](be) Reuse table reader file block#63704
Gabriel39 merged 4 commits into
apache:refact_reader_branchfrom
Gabriel39:refactor_0526

Conversation

@Gabriel39
Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

Gabriel39 added 4 commits May 26, 2026 22:27
### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary: Avoid rebuilding a full file-schema block for every table reader batch. Build a request-shaped reusable file block after opening the reader and reuse its column memory across batches.

### Release note

None

### Check List (For Author)

- Test: Manual test
    - Ran git diff --check. build-support/clang-format.sh could not run because llvm@16 is not installed in this environment.
- Behavior changed: No
- Does this need documentation: No
### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary: Direct ParquetReader tests and callers can build FileScanRequest without column_positions. Fill the legacy file-column-id layout in ParquetReader::open when positions are absent.

### Release note

None

### Check List (For Author)

- Test: Manual test
    - Ran git diff --check. Tried ./run-be-ut.sh --run --filter=NewParquetReaderTest.ReadSingleRowGroupThenEof, but the script stopped before running tests because JAVA_HOME points to JDK 11 and JDK_17 is not set.
- Behavior changed: No
- Does this need documentation: No
@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Gabriel39 Gabriel39 merged commit 5dc54d8 into apache:refact_reader_branch May 27, 2026
10 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants