[fix](test) delete unstable case in agg_strategy#63726
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
run external |
|
/review |
There was a problem hiding this comment.
Automated review summary for PR #63726.
No blocking findings were identified in the changed lines. The PR removes the unstable qt_agg_distinct_satisfy_dst_key_with_other_func shape-plan check and the two matching expected-output blocks generated by the no-stats / with-stats loop, while preserving the same SQL as a result correctness check earlier in the suite.
Critical checkpoint conclusions:
- Goal and proof: The change appears aimed at disabling an unstable shape-plan assertion. The corresponding output deletion matches the removed
qt_statement in both loop iterations, and the result query remains covered. - Scope: The modification is small and focused on one regression case.
- Concurrency: Not applicable; this is regression test metadata only.
- Lifecycle/static initialization: Not applicable.
- Configuration: No configuration items are added or changed.
- Compatibility/storage/protocol: Not applicable; no production behavior or persisted format changes.
- Parallel paths: The low-NDV shape case remains covered separately; no production path change requires parallel implementation.
- Conditional checks: No new conditional checks.
- Test coverage: Coverage is slightly reduced for this specific high-NDV explain shape, but result correctness remains tested and this is consistent with removing an unstable plan-shape assertion.
- Test results: The
.outchanges match the removedqt_case count from the two loop iterations. - Observability: Not applicable.
- Transaction/persistence/data writes: Not applicable.
- FE/BE variable passing: Not applicable.
- Performance: Not applicable.
- User focus points: No additional user-provided review focus was supplied.
Residual note: I did not run the regression suite in this review environment.
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)