Skip to content

[fix](test) delete unstable case in agg_strategy#63726

Merged
morrySnow merged 1 commit into
apache:masterfrom
feiniaofeiafei:delete_unstable_case
May 28, 2026
Merged

[fix](test) delete unstable case in agg_strategy#63726
morrySnow merged 1 commit into
apache:masterfrom
feiniaofeiafei:delete_unstable_case

Conversation

@feiniaofeiafei
Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@feiniaofeiafei
Copy link
Copy Markdown
Contributor Author

run buildall

@feiniaofeiafei
Copy link
Copy Markdown
Contributor Author

run external

@morrySnow
Copy link
Copy Markdown
Contributor

/review

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review summary for PR #63726.

No blocking findings were identified in the changed lines. The PR removes the unstable qt_agg_distinct_satisfy_dst_key_with_other_func shape-plan check and the two matching expected-output blocks generated by the no-stats / with-stats loop, while preserving the same SQL as a result correctness check earlier in the suite.

Critical checkpoint conclusions:

  • Goal and proof: The change appears aimed at disabling an unstable shape-plan assertion. The corresponding output deletion matches the removed qt_ statement in both loop iterations, and the result query remains covered.
  • Scope: The modification is small and focused on one regression case.
  • Concurrency: Not applicable; this is regression test metadata only.
  • Lifecycle/static initialization: Not applicable.
  • Configuration: No configuration items are added or changed.
  • Compatibility/storage/protocol: Not applicable; no production behavior or persisted format changes.
  • Parallel paths: The low-NDV shape case remains covered separately; no production path change requires parallel implementation.
  • Conditional checks: No new conditional checks.
  • Test coverage: Coverage is slightly reduced for this specific high-NDV explain shape, but result correctness remains tested and this is consistent with removing an unstable plan-shape assertion.
  • Test results: The .out changes match the removed qt_ case count from the two loop iterations.
  • Observability: Not applicable.
  • Transaction/persistence/data writes: Not applicable.
  • FE/BE variable passing: Not applicable.
  • Performance: Not applicable.
  • User focus points: No additional user-provided review focus was supplied.

Residual note: I did not run the regression suite in this review environment.

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label May 27, 2026
@github-actions
Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit 1284b25 into apache:master May 28, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants